Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-09 13:52:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: rename rel -> subject in disconnect_rel dispatch

Browse Source 
The "mep-pair-fitting" kind added in the previous commit carries an
IfcFlowFitting (the entity whose deletion disconnects the pair), not a
relationship entity, in the dispatch slot — but the slot was named ``rel``
across the function signature and every call site. Rename to ``subject``
so the parameter name reflects the uniform intent: "the entity whose
teardown effects the disconnect", regardless of whether that's a rel or
a fitting.

Sweep covers:

- core.connection.disconnect_rel signature + body
- tool.Connection.find_rels / find_rels_for_element / find_rel docstrings
- The cascade-on-delete call site in tool.Geometry.delete_ifc_object
- DisconnectElements operator in bim.module.model.wall
- All affected test kwargs and AST forward-compat docstring
- Error message: "Unknown rel kind" -> "Unknown kind"

No behaviour change.

Generated with the assistance of an AI coding tool.
This commit is contained in:
Gorgious56
2026-06-23 14:27:29 +02:00
parent 6fa984ce2b
commit 006a24ef32
8 changed files with 76 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/test/core/test_connection.py
+15 -15
View File
@@ -64,7 +64,7 @@ class TestDisconnectRelPath:
geometry,
model,
connection,
rel="rel",
subject="rel",
kind="path",
elem="elem_a",
partner="elem_b",
@@ -88,7 +88,7 @@ class TestDisconnectRelPath:
geometry,
model,
connection,
rel="rel",
subject="rel",
kind="path",
elem="elem",
partner="partner",
@@ -109,7 +109,7 @@ class TestDisconnectRelPath:
geometry,
model,
connection,
rel="rel",
subject="rel",
kind="path",
elem="elem",
partner="partner",
@@ -130,7 +130,7 @@ class TestDisconnectRelPath:
geometry,
model,
connection,
rel="rel",
subject="rel",
kind="path",
elem="elem",
partner="partner",
@@ -159,7 +159,7 @@ class TestDisconnectRelElementTop:
geometry,
model,
connection,
rel=rel,
subject=rel,
kind="element-top",
elem="elem",
partner="partner",
@@ -182,7 +182,7 @@ class TestDisconnectRelElementTop:
Mock(),
Mock(),
connection,
rel=rel,
subject=rel,
kind="element-top",
elem="slab",
partner="wall",
@@ -205,7 +205,7 @@ class TestDisconnectRelElementTop:
Mock(),
Mock(),
connection,
rel=rel,
subject=rel,
kind="element-top",
elem="wall",
partner="slab",
@@ -229,7 +229,7 @@ class TestDisconnectRelElementTop:
Mock(),
Mock(),
connection,
rel=rel,
subject=rel,
kind="element-top",
elem="slab",
partner="wall",
@@ -250,7 +250,7 @@ class TestDisconnectRelElement:
Mock(),
Mock(),
Mock(),
rel=rel,
subject=rel,
kind="element",
elem="elem_a",
partner="elem_b",
@@ -276,7 +276,7 @@ class TestDisconnectRelMEPPairFitting:
geometry,
Mock(),
Mock(),
rel=fitting,
subject=fitting,
kind="mep-pair-fitting",
elem="seg_a",
partner="seg_b",
@@ -296,7 +296,7 @@ class TestDisconnectRelMEPPairFitting:
geometry,
Mock(),
Mock(),
rel=fitting,
subject=fitting,
kind="mep-pair-fitting",
elem="seg_a",
partner="seg_b",
@@ -316,7 +316,7 @@ class TestDisconnectRelMEPPairFitting:
geometry,
Mock(),
Mock(),
rel=fitting,
subject=fitting,
kind="mep-pair-fitting",
elem=fitting,
partner="other",
@@ -335,7 +335,7 @@ class TestDisconnectRelMEPPairFitting:
geometry,
Mock(),
Mock(),
rel=fitting,
subject=fitting,
kind="mep-pair-fitting",
elem="seg_a",
partner=fitting,
@@ -347,13 +347,13 @@ class TestDisconnectRelMEPPairFitting:
class TestDisconnectRelUnknownKind:
def test_raises_value_error(self):
with pytest.raises(ValueError, match="Unknown rel kind"):
with pytest.raises(ValueError, match="Unknown kind"):
subject.disconnect_rel(
Mock(),
Mock(),
Mock(),
Mock(),
rel="rel",
subject="rel",
kind="bogus",
elem="a",
partner="b",