Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-28 03:05:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable are_holes_and_boundary_pairwise_disjoint() check

Browse Source
This commit is contained in:
Thomas Krijnen
2020-09-28 15:38:19 +02:00
parent 2905900d5c
commit 04ae29759b
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/kernels/cgal/CgalKernel.cpp
+8 -1
View File
@@ -1453,9 +1453,16 @@ bool CgalKernel::convert_impl(const taxonomy::boolean_result* br, ifcopenshell::
CGAL::Polygon_with_holes_2<Kernel_> pwh(p, ++it, loops.end()); CGAL::Polygon_with_holes_2<Kernel_> pwh(p, ++it, loops.end());
CGAL::Gps_segment_traits_2<Kernel_> traits; CGAL::Gps_segment_traits_2<Kernel_> traits;
if (false && !CGAL::are_holes_and_boundary_pairwise_disjoint(pwh, traits)) { if (!CGAL::are_holes_and_boundary_pairwise_disjoint(pwh, traits)) {
// this is very slow. // this is very slow.
// the check is also slow... // the check is also slow...
// It is enabled because in case of overlapping openings the
// even-odd fill rule will result in incorrect results.
// See for example the Duplex model roof.
Logger::Notice("Holes are not disjoint");
CGAL::Polygon_set_2<Kernel_> result; CGAL::Polygon_set_2<Kernel_> result;
auto it = loops.begin(); auto it = loops.begin();
result.insert(*it++); result.insert(*it++);