mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-10 09:48:32 +00:00
Window Modifier - added mullions/transoms, removed relative panel dimensions
This commit is contained in:
Andrej730
@@ -62,18 +62,17 @@ class Usecase:
|
||||
"LiningToPanelOffsetX": 25,
|
||||
"LiningToPanelOffsetY": 25,
|
||||
# applies to DoublePanelVertical, TriplePanelBottom, TriplePanelTop, TriplePanelLeft, TriplePanelRight
|
||||
# mullion - distance between panels
|
||||
"FirstMullionOffset": ..., # distance from the first lining to the mullion
|
||||
# TODO: take mullion thickness into account
|
||||
"MullionThickness": ...,
|
||||
# mullion - horizontal distance between panels
|
||||
"MullionThickness": 50,
|
||||
"FirstMullionOffset": 300, # distance from the first lining to the mullion center
|
||||
# applies to TriplePanelVertical
|
||||
"SecondMullionOffset": 450, # distance from the first lining to the second mullion
|
||||
# applies to DoublePanelHorizontal, TriplePanelBottom, TriplePanelTop, TriplePanelLeft, TriplePanelRight
|
||||
# works similar way to mullion
|
||||
"FirstTransomOffset": ...,
|
||||
"TransomThickness": ...,
|
||||
# applies to TriplePanelVertical
|
||||
"SecondMullionOffset": ..., # distance from the first lining to the second mullion
|
||||
"TransomThickness": 50,
|
||||
"FirstTransomOffset": 300,
|
||||
# applies to TriplePanelHorizontal
|
||||
"SecondTransomOffset": ...,
|
||||
"SecondTransomOffset": 600,
|
||||
"ShapeAspectStyle": None, # DEPRECATED
|
||||
},
|
||||
"panel_properties": [
|
||||
@@ -86,10 +85,6 @@ class Usecase:
|
||||
# how it's hanged, how it opens
|
||||
"OperationType": None,
|
||||
"ShapeAspectStyle": None, # DEPRECATED
|
||||
# Custom Parameter not available in IFC
|
||||
# dimensions of the panel relative to overall window dimensions
|
||||
"RelativeWidth": 1.0,
|
||||
"RelativeHeight": 1.0,
|
||||
},
|
||||
],
|
||||
}
|
||||
@@ -98,19 +93,6 @@ class Usecase:
|
||||
self.settings[key] = value
|
||||
self.settings["panel_schema"] = DEFAULT_PANEL_SCHEMAS[self.settings["partition_type"]]
|
||||
|
||||
# recalculate relative width and height to avoid errors
|
||||
# TODO: rework or remove
|
||||
# panels_data = self.settings['panel_properties']
|
||||
# current_height = sum(p['RelativeHeight'] for p in panels_data)
|
||||
# current_width = sum(p['RelativeWidth'] for p in panels_data)
|
||||
|
||||
# for p in panels_data:
|
||||
# if current_height != 1.0:
|
||||
# p['RelativeHeight'] = p['RelativeHeight'] / current_height
|
||||
|
||||
# if current_width != 1.0:
|
||||
# p['RelativeWidth'] = p['RelativeWidth'] / current_width
|
||||
|
||||
def execute(self):
|
||||
self.settings["unit_scale"] = ifcopenshell.util.unit.calculate_unit_scale(self.file)
|
||||
builder = ShapeBuilder(self.file)
|
||||
@@ -135,19 +117,54 @@ class Usecase:
|
||||
lining_panel_offset_y = self.convert_si_to_unit(self.settings["lining_properties"]["LiningToPanelOffsetY"])
|
||||
glass_thickness = self.convert_si_to_unit(10)
|
||||
|
||||
for row_i, panel_row in enumerate(reversed(panel_schema)):
|
||||
mullion_thickness = self.convert_si_to_unit(self.settings["lining_properties"]["MullionThickness"]) / 2
|
||||
first_mullion_offset = self.convert_si_to_unit(self.settings["lining_properties"]["FirstMullionOffset"])
|
||||
second_mullion_offset = self.convert_si_to_unit(self.settings["lining_properties"]["SecondMullionOffset"])
|
||||
transom_thickness = self.convert_si_to_unit(self.settings["lining_properties"]["TransomThickness"]) / 2
|
||||
first_transom_offset = self.convert_si_to_unit(self.settings["lining_properties"]["FirstTransomOffset"])
|
||||
second_transom_offset = self.convert_si_to_unit(self.settings["lining_properties"]["SecondTransomOffset"])
|
||||
|
||||
panel_schema = list(reversed(panel_schema))
|
||||
|
||||
# TODO: need more readable way to define panel width and height
|
||||
unique_rows_in_col = [
|
||||
len(set(row[column_i] for row in panel_schema)) for column_i in range(len(panel_schema[0]))
|
||||
]
|
||||
for row_i, panel_row in enumerate(panel_schema):
|
||||
accumulated_width = 0
|
||||
unique_cols = len(set(panel_row))
|
||||
|
||||
for column_i, panel_i in enumerate(panel_row):
|
||||
# calculate current panel dimensions
|
||||
if unique_cols > 1:
|
||||
if column_i == 0:
|
||||
panel_width = first_mullion_offset
|
||||
elif column_i == unique_cols - 1:
|
||||
panel_width = overall_width - accumulated_width
|
||||
else:
|
||||
panel_width = second_mullion_offset - accumulated_width
|
||||
else:
|
||||
panel_width = overall_width
|
||||
|
||||
if unique_rows_in_col[column_i] > 1:
|
||||
if row_i == 0:
|
||||
panel_height = first_transom_offset
|
||||
elif row_i == unique_rows_in_col[column_i] - 1:
|
||||
panel_height = overall_height - accumulated_height[column_i]
|
||||
else:
|
||||
panel_height = second_transom_offset - accumulated_height[column_i]
|
||||
else:
|
||||
panel_height = overall_height
|
||||
|
||||
if panel_i in built_panels:
|
||||
accumulated_height[column_i] += cur_panel["RelativeHeight"]
|
||||
accumulated_width += cur_panel["RelativeWidth"]
|
||||
accumulated_height[column_i] += panel_height
|
||||
accumulated_width += panel_width
|
||||
continue
|
||||
|
||||
cur_panel = panels[panel_i]
|
||||
current_items = []
|
||||
panel_depth = self.convert_si_to_unit(cur_panel["FrameDepth"])
|
||||
panel_thickness = self.convert_si_to_unit(cur_panel["FrameThickness"])
|
||||
panel_height = cur_panel["RelativeHeight"] * overall_height
|
||||
panel_width = cur_panel["RelativeWidth"] * overall_width
|
||||
|
||||
panel_actual_width = panel_width - lining_panel_offset_x * 2
|
||||
panel_actual_height = panel_height - lining_panel_offset_x * 2
|
||||
@@ -156,99 +173,121 @@ class Usecase:
|
||||
glass_height = panel_actual_height - panel_thickness * 2
|
||||
|
||||
# build lining
|
||||
lining_items_vertical = []
|
||||
lining_items = []
|
||||
# lining is calculated on panel level because
|
||||
# panel depth is used
|
||||
lining_rectangle = builder.rectangle(size=V(lining_thickness, lining_depth))
|
||||
lining_items_vertical_left = []
|
||||
lining_items = []
|
||||
|
||||
# need to check offsets to decide whether lining should be rectangle
|
||||
# or L shaped
|
||||
if lining_panel_offset_x >= lining_thickness or lining_panel_offset_y >= lining_depth:
|
||||
lining_vertical_polyline = ifcopenshell.util.element.copy_deep(self.file, lining_rectangle)
|
||||
lining_vertical_height = panel_height
|
||||
# calculate lining thickness
|
||||
# taking into account mullions and transoms
|
||||
thickness = [lining_thickness] * 4
|
||||
# mullion thickness
|
||||
if unique_cols > 1:
|
||||
if column_i != 0:
|
||||
thickness[0] = mullion_thickness # left column
|
||||
if column_i != unique_cols - 1:
|
||||
thickness[2] = mullion_thickness # right column
|
||||
# transom thickness
|
||||
if unique_rows_in_col[column_i] > 1:
|
||||
if row_i != 0:
|
||||
thickness[3] = transom_thickness # bottom row
|
||||
if row_i != unique_rows_in_col[column_i] - 1:
|
||||
thickness[1] = transom_thickness # top row
|
||||
|
||||
else:
|
||||
lining_points = [
|
||||
V(0, 0),
|
||||
V(0, lining_depth),
|
||||
V(lining_panel_offset_x, lining_depth),
|
||||
V(lining_panel_offset_x, lining_depth - (panel_depth - lining_panel_offset_y)),
|
||||
V(lining_thickness, lining_depth - (panel_depth - lining_panel_offset_y)),
|
||||
V(lining_thickness, 0),
|
||||
]
|
||||
def get_lining_rectangle(current_lining_thickness):
|
||||
lining_rectangle = builder.rectangle(size=V(current_lining_thickness, lining_depth))
|
||||
return lining_rectangle
|
||||
|
||||
# lining vertical
|
||||
lining_vertical_polyline = builder.polyline(lining_points, closed=True)
|
||||
def get_lining_polyline(current_lining_thickness):
|
||||
# need to check offsets to decide whether lining should be rectangle
|
||||
# or L shaped
|
||||
if lining_panel_offset_x >= current_lining_thickness or lining_panel_offset_y >= lining_depth:
|
||||
lining_polyline = get_lining_rectangle(current_lining_thickness)
|
||||
else:
|
||||
lining_points = [
|
||||
V(0, 0),
|
||||
V(0, lining_depth),
|
||||
V(lining_panel_offset_x, lining_depth),
|
||||
V(lining_panel_offset_x, lining_depth - (panel_depth - lining_panel_offset_y)),
|
||||
V(current_lining_thickness, lining_depth - (panel_depth - lining_panel_offset_y)),
|
||||
V(current_lining_thickness, 0),
|
||||
]
|
||||
lining_polyline = builder.polyline(lining_points, closed=True)
|
||||
return lining_polyline
|
||||
|
||||
def create_lining_vertical(current_lining_thickness):
|
||||
current_vertical_lining_items = []
|
||||
lining_vertical_polyline = get_lining_polyline(current_lining_thickness)
|
||||
lining_vertical_height = panel_height - lining_panel_offset_x * 2
|
||||
extrusion_position = V(0, 0, lining_panel_offset_x)
|
||||
lining_vertical_extruded = builder.extrude(
|
||||
lining_vertical_polyline, lining_vertical_height, position=extrusion_position
|
||||
)
|
||||
current_vertical_lining_items.append(lining_vertical_extruded)
|
||||
|
||||
# if lining panel X offset is present
|
||||
# then we also need to add two more box shapes
|
||||
# to finish the lining after the panel ends
|
||||
if lining_panel_offset_x > 0:
|
||||
lining_vertical_addition = builder.extrude(
|
||||
builder.deep_copy(lining_rectangle), lining_panel_offset_x
|
||||
get_lining_rectangle(current_lining_thickness), lining_panel_offset_x
|
||||
)
|
||||
|
||||
lining_items_vertical.extend(
|
||||
[
|
||||
current_vertical_lining_items.append(lining_vertical_addition)
|
||||
current_vertical_lining_items.append(
|
||||
builder.translate(
|
||||
lining_vertical_addition,
|
||||
builder.translate(
|
||||
lining_vertical_addition,
|
||||
V(0, 0, panel_height - lining_panel_offset_x),
|
||||
create_copy=True,
|
||||
),
|
||||
]
|
||||
V(0, 0, panel_height - lining_panel_offset_x),
|
||||
create_copy=True,
|
||||
)
|
||||
)
|
||||
|
||||
# horizontal lining
|
||||
lining_horizontal_polyline = builder.deep_copy(lining_vertical_polyline)
|
||||
return current_vertical_lining_items
|
||||
|
||||
# vertical lining
|
||||
lining_items_vertical_left = create_lining_vertical(thickness[0])
|
||||
lining_items_vertical_right = create_lining_vertical(thickness[2])
|
||||
lining_items_vertical_right = builder.mirror(
|
||||
lining_items_vertical_right, mirror_point=V(panel_width / 2, 0), mirror_axes=V(1, 0)
|
||||
)
|
||||
lining_items.extend(lining_items_vertical_left)
|
||||
lining_items.extend(lining_items_vertical_right)
|
||||
|
||||
# horizontal lining
|
||||
def create_horizontal_lining(current_lining_thickness, mirror_point=None):
|
||||
lining_horizontal_polyline = get_lining_polyline(current_lining_thickness)
|
||||
if mirror_point:
|
||||
lining_horizontal_polyline = builder.mirror(
|
||||
lining_horizontal_polyline,
|
||||
mirror_axes=V(1, 0),
|
||||
mirror_point=mirror_point
|
||||
)
|
||||
builder.translate(lining_horizontal_polyline, -mirror_point)
|
||||
lining_horizontal_extruded = builder.extrude(
|
||||
lining_horizontal_polyline,
|
||||
magnitude=panel_width - 2 * lining_thickness,
|
||||
magnitude=panel_width - (thickness[0] + thickness[2]),
|
||||
extrusion_vector=V(0, 0, -1),
|
||||
position_z_axis=V(-1, 0, 0),
|
||||
position_x_axis=V(0, 0, 1),
|
||||
position=V(lining_thickness, 0, 0),
|
||||
)
|
||||
return lining_horizontal_extruded
|
||||
|
||||
# TODO: should implement mirror by Z for more readability
|
||||
# TODO: investigate meaning of mirror axes in case of custom x/y/z space
|
||||
# lining_horizontal_mirrored = builder.mirror(
|
||||
# lining_horizontal_extruded,
|
||||
# mirror_point=V(0, panel_height/2),
|
||||
# mirror_axes=V(0,1),
|
||||
# create_copy=True
|
||||
# )
|
||||
lining_horizontal_bottom = create_horizontal_lining(thickness[3])
|
||||
builder.translate(lining_horizontal_bottom, V(thickness[0], 0, 0))
|
||||
|
||||
lining_horizontal_polyline_mirrored = builder.mirror(
|
||||
lining_horizontal_polyline,
|
||||
mirror_axes=V(1, 0),
|
||||
mirror_point=V(lining_thickness, 0),
|
||||
create_copy=True,
|
||||
)
|
||||
lining_horizontal_mirrored = builder.extrude(
|
||||
lining_horizontal_polyline_mirrored,
|
||||
magnitude=panel_width - 2 * lining_thickness,
|
||||
extrusion_vector=V(0, 0, -1),
|
||||
position_z_axis=V(-1, 0, 0),
|
||||
position_x_axis=V(0, 0, 1),
|
||||
position=V(lining_thickness, 0, panel_height - lining_thickness * 2),
|
||||
)
|
||||
lining_items.extend([lining_horizontal_extruded, lining_horizontal_mirrored])
|
||||
lining_horizontal_top = create_horizontal_lining(thickness[1], mirror_point=V(thickness[1], 0))
|
||||
builder.translate(lining_horizontal_top, V(thickness[0], 0, panel_height - thickness[1]))
|
||||
|
||||
extrusion_position = V(0, 0, lining_panel_offset_x)
|
||||
lining_vertical_extruded = builder.extrude(
|
||||
lining_vertical_polyline, lining_vertical_height, position=extrusion_position
|
||||
)
|
||||
lining_items_vertical.append(lining_vertical_extruded)
|
||||
# TODO: should implement mirror by Z for more readability
|
||||
# TODO: investigate meaning of mirror axes in case of custom x/y/z space
|
||||
# lining_horizontal_mirrored = builder.mirror(
|
||||
# lining_horizontal_extruded,
|
||||
# mirror_point=V(0, panel_height/2),
|
||||
# mirror_axes=V(0,1),
|
||||
# create_copy=True
|
||||
# )
|
||||
|
||||
lining_items_vertical_mirrored = builder.mirror(
|
||||
lining_items_vertical, mirror_point=V(panel_width / 2, 0), mirror_axes=V(1, 0), create_copy=True
|
||||
)
|
||||
|
||||
lining_items.extend(lining_items_vertical)
|
||||
lining_items.extend(lining_items_vertical_mirrored)
|
||||
lining_items.extend([lining_horizontal_bottom, lining_horizontal_top])
|
||||
current_items.extend(lining_items)
|
||||
|
||||
# PANEL
|
||||
@@ -278,16 +317,14 @@ class Usecase:
|
||||
current_items.append(glass)
|
||||
|
||||
# translate panel
|
||||
accumulated_offset = V(accumulated_width, 0, accumulated_height[column_i]) * V(
|
||||
overall_width, 0, overall_height
|
||||
)
|
||||
accumulated_offset = V(accumulated_width, 0, accumulated_height[column_i])
|
||||
builder.translate(current_items, accumulated_offset)
|
||||
|
||||
built_panels.append(panel_i)
|
||||
window_items.extend(current_items)
|
||||
|
||||
accumulated_height[column_i] += cur_panel["RelativeHeight"]
|
||||
accumulated_width += cur_panel["RelativeWidth"]
|
||||
accumulated_height[column_i] += panel_height
|
||||
accumulated_width += panel_width
|
||||
|
||||
builder.translate(window_items, V(0, lining_offset, 0)) # wall offset
|
||||
representation = builder.get_representation(self.settings["context"], window_items)
|
||||
@@ -295,120 +332,3 @@ class Usecase:
|
||||
|
||||
def convert_si_to_unit(self, value):
|
||||
return value * 0.001 / self.settings["unit_scale"]
|
||||
|
||||
|
||||
# TODO: remove test at the end
|
||||
if __name__ == "__main__":
|
||||
ifc_file = ifcopenshell.file()
|
||||
project = ifcopenshell.api.run(
|
||||
"root.create_entity", ifc_file, ifc_class="IfcProject", name=f"Non-structural assets library"
|
||||
)
|
||||
library = ifcopenshell.api.run(
|
||||
"root.create_entity", ifc_file, ifc_class="IfcProjectLibrary", name=f"Non-structural assets library"
|
||||
)
|
||||
ifcopenshell.api.run("project.assign_declaration", ifc_file, definition=library, relating_context=project)
|
||||
unit = ifcopenshell.api.run("unit.add_si_unit", ifc_file, unit_type="LENGTHUNIT", name="METRE", prefix="MILLI")
|
||||
ifcopenshell.api.run("unit.assign_unit", ifc_file, units=[unit])
|
||||
model = ifcopenshell.api.run("context.add_context", ifc_file, context_type="Model")
|
||||
plan = ifcopenshell.api.run("context.add_context", ifc_file, context_type="Plan")
|
||||
|
||||
representations = {
|
||||
"body": ifcopenshell.api.run(
|
||||
"context.add_context",
|
||||
ifc_file,
|
||||
context_type="Model",
|
||||
context_identifier="Body",
|
||||
target_view="MODEL_VIEW",
|
||||
parent=model,
|
||||
),
|
||||
"elevation": ifcopenshell.api.run(
|
||||
"context.add_context",
|
||||
ifc_file,
|
||||
context_type="Model",
|
||||
context_identifier="Profile",
|
||||
target_view="ELEVATION_VIEW",
|
||||
parent=model,
|
||||
),
|
||||
"annotation": ifcopenshell.api.run(
|
||||
"context.add_context",
|
||||
ifc_file,
|
||||
context_type="Plan",
|
||||
context_identifier="Annotation",
|
||||
target_view="PLAN_VIEW",
|
||||
parent=plan,
|
||||
),
|
||||
}
|
||||
|
||||
settings = {
|
||||
"context": representations["body"],
|
||||
# SINGLE_PANEL, DOUBLE_PANEL_HORIZONTAL, DOUBLE_PANEL_VERTICAL,
|
||||
# TRIPLE_PANEL_BOTTOM, TRIPLE_PANEL_HORIZONTAL, TRIPLE_PANEL_LEFT, TRIPLE_PANEL_RIGHT, TRIPLE_PANEL_TOP, TRIPLE_PANEL_VERTICAL
|
||||
"partition_type": "TRIPLE_PANEL_RIGHT",
|
||||
"overall_height": 900,
|
||||
"overall_width": 600 * 3,
|
||||
# "lining_properties": {
|
||||
# 'LiningDepth': 50,
|
||||
# 'LiningThickness': 50,
|
||||
# 'LiningOffset': 50, # offset to the wall
|
||||
# 'LiningToPanelOffsetX': 25,
|
||||
# 'LiningToPanelOffsetY': 25,
|
||||
# # applies to DoublePanelVertical, TriplePanelBottom, TriplePanelTop, TriplePanelLeft, TriplePanelRight
|
||||
# # mullion - distance between panels
|
||||
# 'FirstMullionOffset': ..., # distance from the first lining to the mullion
|
||||
# # TODO: take mullion thickness into account
|
||||
# 'MullionThickness': ...,
|
||||
# # applies to DoublePanelHorizontal, TriplePanelBottom, TriplePanelTop, TriplePanelLeft, TriplePanelRight
|
||||
# # works similar way to mullion
|
||||
# 'FirstTransomOffset': ...,
|
||||
# 'TransomThickness': ...,
|
||||
# # applies to TriplePanelVertical
|
||||
# 'SecondMullionOffset': ..., # distance from the first lining to the second mullion
|
||||
# # applies to TriplePanelHorizontal
|
||||
# 'SecondTransomOffset': ...,
|
||||
# 'ShapeAspectStyle': None, # DEPRECATED
|
||||
# },
|
||||
"panel_properties": [
|
||||
{
|
||||
"FrameDepth": 35, # by Y
|
||||
"FrameThickness": 35, # by X
|
||||
"RelativeWidth": 1.0 / 2,
|
||||
"RelativeHeight": 1.0 / 2,
|
||||
},
|
||||
{
|
||||
"FrameDepth": 35, # by Y
|
||||
"FrameThickness": 35, # by X
|
||||
"RelativeWidth": 1.0 / 2,
|
||||
"RelativeHeight": 1.0,
|
||||
},
|
||||
{
|
||||
"FrameDepth": 35, # by Y
|
||||
"FrameThickness": 35, # by X
|
||||
"RelativeWidth": 1.0 / 2,
|
||||
"RelativeHeight": 1.0 / 2,
|
||||
},
|
||||
],
|
||||
}
|
||||
# builder = ShapeBuilder(ifc_file)
|
||||
# points = [V(0,0), V(5,1)]
|
||||
# print(points)
|
||||
# base_point = V(2,2)
|
||||
# points = [p + base_point for p in points]
|
||||
# points = [builder.mirror_2d_point(p, mirror_axes=V(0,1), mirror_point=V(3,3)) for p in points]
|
||||
# print('mirrored')
|
||||
# print(points)
|
||||
# print('mirrored base point')
|
||||
# base_point = builder.mirror_2d_point(base_point, mirror_axes=V(0,1), mirror_point=V(3,3))
|
||||
# print(base_point)
|
||||
# print('base line')
|
||||
# print([p - base_point for p in points])
|
||||
|
||||
use_case = Usecase(ifc_file, **settings)
|
||||
representation = use_case.execute()
|
||||
print(representation)
|
||||
|
||||
settings["context"] = representations["elevation"]
|
||||
use_case = Usecase(ifc_file, **settings)
|
||||
representation_2d = use_case.execute()
|
||||
print(representation_2d)
|
||||
|
||||
ifc_file.write("tmp.ifc")
|
||||
|
||||
Reference in New Issue
Block a user