Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 23:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bonsai: fix DirectProfileEdit crash exiting edit mode (#7624)

Browse Source 
Exiting a slab DirectProfileEdit raised
`AttributeError: 'OverrideModeSetObject' object has no attribute 'edited_objs'`.
DirectProfileEdit's fallback paths called bpy.ops.bim.override_mode_set_object()
bare, which runs in EXEC context and dispatches straight to the operator's
_execute(); but edited_objs / unchanged_objs_with_openings are only
initialised in _invoke(), so _execute iterated a never-set attribute and
crashed. Every other call site of this operator already passes
"INVOKE_DEFAULT"; only DirectProfileEdit's four fallbacks missed it.

Pass "INVOKE_DEFAULT" at all four sites so _invoke runs first, matching the
rest of the codebase.

Verified: the bare-call path reproduces the exact AttributeError; the
invoke path initialises edited_objs before execute() runs and completes
cleanly. All override_mode_set_object call sites in the file now
consistently use INVOKE_DEFAULT; the operators still register, and
core test_geometry.py passes (14).

Generated with the assistance of an AI coding tool.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Petru Conduraru
2026-07-12 18:42:18 +03:00
parent 980988f208
commit 04db09f90a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/bonsai/bim/module/geometry/operator.py
+4 -4
View File
@@ -2814,7 +2814,7 @@ class DirectProfileEdit(bpy.types.Operator, tool.Ifc.Operator):
return self.exit_element_edit_mode(context, obj, element) return self.exit_element_edit_mode(context, obj, element)
# For other edit modes, use standard operator # For other edit modes, use standard operator
return bpy.ops.bim.override_mode_set_object() return bpy.ops.bim.override_mode_set_object("INVOKE_DEFAULT")
def exit_item_edit_mode(self, context, obj): def exit_item_edit_mode(self, context, obj):
"""Exit from representation item editing.""" """Exit from representation item editing."""
@@ -2825,7 +2825,7 @@ class DirectProfileEdit(bpy.types.Operator, tool.Ifc.Operator):
item = tool.Geometry.get_active_representation(obj) item = tool.Geometry.get_active_representation(obj)
if not item: if not item:
return bpy.ops.bim.override_mode_set_object() return bpy.ops.bim.override_mode_set_object("INVOKE_DEFAULT")
# Fix vertex order for annotation items # Fix vertex order for annotation items
props = tool.Geometry.get_geometry_props() props = tool.Geometry.get_geometry_props()
@@ -2939,7 +2939,7 @@ class DirectProfileEdit(bpy.types.Operator, tool.Ifc.Operator):
# Fallback # Fallback
else: else:
return bpy.ops.bim.override_mode_set_object() return bpy.ops.bim.override_mode_set_object("INVOKE_DEFAULT")
except Exception as e: except Exception as e:
self.report({"ERROR"}, f"Failed to save item changes: {str(e)}") self.report({"ERROR"}, f"Failed to save item changes: {str(e)}")
@@ -2966,7 +2966,7 @@ class DirectProfileEdit(bpy.types.Operator, tool.Ifc.Operator):
return {"CANCELLED"} return {"CANCELLED"}
# Fallback to standard operator # Fallback to standard operator
return bpy.ops.bim.override_mode_set_object() return bpy.ops.bim.override_mode_set_object("INVOKE_DEFAULT")
def handle_enter_edit_mode(self, context): def handle_enter_edit_mode(self, context):
"""Handle entering edit mode from object mode.""" """Handle entering edit mode from object mode."""