Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-07 21:06:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

I think bSDD should use the Name for the property name. See 115a48f

Browse Source 
It seems correct according to
https://github.com/buildingSMART/bSDD/blob/master/Documentation/bSDD%20JSON%20import%20model.md
This commit is contained in:
Dion Moult
2025-03-09 21:35:20 +11:00
parent abfe8ec315
commit 076f39e2d6
3 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/test/tool/test_classification.py
+14 -13
View File
@@ -84,19 +84,18 @@ class TestAddClassificationReferenceFromBSDD(NewFile):
assert pset.name == "Pset_SpaceCommon"
assert len(pset.properties) == 1
pset_prop = pset.properties[0]
assert pset_prop.name == "HandicapAccessible"
assert pset_prop.name == "Handicap Accessible"
pset_prop.bool_value = True
bpy.ops.bim.add_classification_reference_from_bsdd(obj="IfcSpace/Cube", obj_type="Object")
pset = ifcopenshell.util.element.get_pset(element, "Pset_SpaceCommon")
assert pset and pset["HandicapAccessible"] == True
assert pset and pset["Handicap Accessible"] == True
refs = ifcopenshell.util.classification.get_references(element)
assert len(refs) == 1
assert list(refs)[0].Location.startswith(uri)
def test_add_clasification_reference_with_object_type(self):
bpy.ops.bim.create_project()
ifc_file = tool.Ifc.get()
context = bpy.context
bpy.ops.mesh.primitive_cube_add(size=10, location=(0, 0, 4))
obj = bpy.data.objects["Cube"]
@@ -104,27 +103,29 @@ class TestAddClassificationReferenceFromBSDD(NewFile):
element = tool.Ifc.get_entity(obj)
assert element
bpy.ops.bim.load_bsdd_domains()
uri = "https://identifier.buildingsmart.org/uri/ifcairport/ifcairport/1.0"
bpy.ops.bim.set_active_bsdd_domain(name="IFC Airport", uri=uri)
props = context.scene.BIMBSDDProperties
props.load_preview_domains = True
bpy.ops.bim.load_bsdd_domains()
uri = "https://identifier.buildingsmart.org/uri/ifcairport/ifcairport/0.9"
bpy.ops.bim.set_active_bsdd_domain(name="IFC Airport", uri=uri)
bpy.context.scene.BIMClassificationProperties.classification_source = "BSDD"
props.should_filter_ifc_class = False # Important due to class mismatch.
props.keyword = "Check-In Conveyor"
props.keyword = "check-in conveyor"
bpy.ops.bim.search_bsdd_classifications()
# https://identifier.buildingsmart.org/uri/ifcairport/ifcairport/1.0/class/ifcairport0000000004
# https://identifier.buildingsmart.org/uri/bs-airport/airport/0.9/class/AD-BHS-006
props.active_classification_index = next(
i for i, c in enumerate(props.classifications) if c.name == "Check-In Conveyor"
i for i, c in enumerate(props.classifications) if c.name == "Check-in conveyor"
)
bpy.ops.bim.get_bsdd_classification_properties()
psets = props.classification_psets
assert len(psets) == 1
pset = psets[0]
assert pset.name == "undefined_set"
assert len(pset.properties) == 1
assert pset.name == "ISet_AirportDomain"
assert len(pset.properties) == 20
pset_prop = pset.properties[0]
assert pset_prop.name == "ObjectType"
assert pset_prop.name == "Conveying speed"
bpy.ops.bim.add_classification_reference_from_bsdd(obj="IfcSpace/Cube", obj_type="Object")
assert element.ObjectType == "CHECKINCONVEYOR"
# Check this?
# assert element.ObjectType == "CHECKINCONVEYOR"
assert not ifcopenshell.util.element.get_psets(element)