From 07825b744284678f7a06cf683e96829673a3051f Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Mon, 1 Jun 2026 18:16:19 +1000 Subject: [PATCH] ifcviewer-wgpu-minimal: add BUNDLE DESTINATION for macOS install rule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The target has MACOSX_BUNDLE ON, which on Darwin requires install(TARGETS) to specify a BUNDLE DESTINATION — CMake validates that at configure time, even when nobody runs `make install`. The macOS CI configure step failed with: install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable target "IfcViewerWgpuMinimal". Set BUNDLE DESTINATION bin alongside RUNTIME DESTINATION bin so both platforms install into the same spot. No behavioural change on Linux (no MACOSX_BUNDLE) — verified locally. Co-Authored-By: Claude Opus 4.7 --- src/ifcviewer-wgpu-minimal/CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/ifcviewer-wgpu-minimal/CMakeLists.txt b/src/ifcviewer-wgpu-minimal/CMakeLists.txt index b2c0a94cd9..2ef2edfcca 100644 --- a/src/ifcviewer-wgpu-minimal/CMakeLists.txt +++ b/src/ifcviewer-wgpu-minimal/CMakeLists.txt @@ -45,5 +45,12 @@ if(UNIX AND NOT APPLE AND WGPU_NATIVE_LIB_DIR) ) endif() -install(TARGETS IfcViewerWgpuMinimal EXPORT ${IFCOPENSHELL_EXPORT_TARGETS}) +# MACOSX_BUNDLE targets require BUNDLE DESTINATION at install time even +# when nobody is going to run `make install` (CMake validates the rule +# at configure). Provide one alongside the regular bin/ runtime path. +install(TARGETS IfcViewerWgpuMinimal + EXPORT ${IFCOPENSHELL_EXPORT_TARGETS} + RUNTIME DESTINATION bin + BUNDLE DESTINATION bin +) ifcopenshell_deploy_qt_runtime(IfcViewerWgpuMinimal)