Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 06:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Limit boolean fuzz to edge length

Browse Source
This commit is contained in:
Thomas Krijnen
2018-05-13 09:15:06 +02:00
parent 68eab4310c
commit 082f16006a
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomFunctions.cpp
+15 -2
View File
@@ -3086,9 +3086,22 @@ bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a, const TopTools_Li
if (fuzziness < 0.) { if (fuzziness < 0.) {
fuzziness = getValue(GV_PRECISION); fuzziness = getValue(GV_PRECISION);
} }
double min_edge_len = std::numeric_limits<double>::infinity();
// ... to be sure to get consecutive edges
TopExp_Explorer exp(a, TopAbs_EDGE);
for (; exp.More(); exp.Next()) {
GProp_GProps prop;
BRepGProp::LinearProperties(exp.Current(), prop);
double l = prop.Mass();
if (l < min_edge_len) {
min_edge_len = l;
}
}
TopTools_ListOfShape s1s; TopTools_ListOfShape s1s;
s1s.Append(copy_operand(a)); s1s.Append(copy_operand(a));
builder->SetFuzzyValue(fuzziness); builder->SetFuzzyValue((std::min)(min_edge_len / 3., fuzziness));
builder->SetArguments(s1s); builder->SetArguments(s1s);
builder->SetTools(copy_operand(b)); builder->SetTools(copy_operand(b));
builder->Build(); builder->Build();
@@ -3112,7 +3125,7 @@ bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a, const TopTools_Li
delete builder; delete builder;
if (!success) { if (!success) {
const double new_fuzziness = fuzziness * 10.; const double new_fuzziness = fuzziness * 10.;
if (new_fuzziness + 1e-15 <= getValue(GV_PRECISION) * 1000.) { if (new_fuzziness + 1e-15 <= getValue(GV_PRECISION) * 1000. && new_fuzziness < min_edge_len) {
return boolean_operation(a, b, op, result, new_fuzziness); return boolean_operation(a, b, op, result, new_fuzziness);
} }
} }