Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 22:50:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #7331: derive cost item quantities from IfcSpace base quantities

Browse Source 
assign_cost_item_quantity skipped every IfcSpatialElement, which also
swallowed IfcSpace. Spaces are legitimate quantifiable objects, so their
Qto_SpaceBaseQuantities (for example GrossFloorArea) were never picked up
and count based cost items fell back to 0. Keep skipping spatial
containers (site, building, storey) but allow IfcSpace.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit e23142d01a)
This commit is contained in:
Petru Conduraru
2026-07-09 07:27:56 +03:00
committed by Dion Moult
parent 3f42e02cb4
commit 0bac7f5542
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/cost/assign_cost_item_quantity.py
+1 -1
View File
@@ -137,7 +137,7 @@ class Usecase:
if self.prop_name or formula: if self.prop_name or formula:
self.quantities = set(cost_item.CostQuantities or []) self.quantities = set(cost_item.CostQuantities or [])
for product in products: for product in products:
if product.is_a("IfcSpatialElement"): if product.is_a("IfcSpatialElement") and not product.is_a("IfcSpace"):
continue continue
ifcopenshell.api.control.assign_control( ifcopenshell.api.control.assign_control(
self.file, self.file,