From 0d3543fa31a7bf33951a82b3e50a03aec9f2dad0 Mon Sep 17 00:00:00 2001 From: Gorgious56 Date: Mon, 1 Jun 2026 10:48:09 +0200 Subject: [PATCH] Drop duplicate _path_connection_location_world in wall.py PR3 shipped tool.Wall.path_connection_location_world; the local _path_connection_location_world added in PR4 commit 70845e4dd duplicated the same logic. The only caller in wall.py already uses the tool method (line 3687 area), so the local helper has been dead code since the migration in 7e5e7b8d6 routed _get_wall_geom_cached to tool.Wall.read_geometry. Drop it. Generated with the assistance of an AI coding tool. --- src/bonsai/bonsai/bim/module/model/wall.py | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/bonsai/bonsai/bim/module/model/wall.py b/src/bonsai/bonsai/bim/module/model/wall.py index a0658574ff..a6b17ea1b4 100644 --- a/src/bonsai/bonsai/bim/module/model/wall.py +++ b/src/bonsai/bonsai/bim/module/model/wall.py @@ -2475,28 +2475,6 @@ def _collinear_boundary_world(seg_a: tuple[Vector, Vector], seg_b: tuple[Vector, ) -def _path_connection_location_world( - seg_self: tuple[Vector, Vector], - self_conn_type: str, - seg_other: tuple[Vector, Vector], - other_conn_type: str, - parallel_threshold: float = 0.9994, -) -> Vector: - """Vector wrapper around `core.compute_path_connection_location`. Used by the - single-wall unjoin gizmo group to place one icon per ``IfcRelConnectsPathElements`` - at its physical join point (an endpoint of the end-connected wall, or the - axis intersection for an ATPATH/ATPATH cross junction).""" - return Vector( - core.compute_path_connection_location( - (tuple(seg_self[0]), tuple(seg_self[1])), - self_conn_type, - (tuple(seg_other[0]), tuple(seg_other[1])), - other_conn_type, - parallel_threshold, - ) - ) - - def _iter_path_connections( elem: ifcopenshell.entity_instance, ) -> list[tuple[ifcopenshell.entity_instance, str, str]]: