From 0e5008d21eb63e27bc01c23c04e00926fa893225 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Thu, 17 Oct 2024 17:57:59 +0500 Subject: [PATCH] Bonsai daily build tag to include hours and minutes The problem is index.json is using urls pointing to zip files from the releases and it's possible that installation from unstable repo will be broken (user will get error message like '"Archive size mismatch "bonsai", expected 87417726, was 87418259"') in 2 cases: 1) during 5 minutes after commit while builds are still uploaded to the releases but index.json is not yet updated 2) if some builds were uploaded and some builds failed to upload, then for platforms that were uploaded successfully unstable installation will be broken until we fix the builds When we add hours and minutes to the tag, that should be enough to make urls unique for each build avoiding this problem. If needed we can came up with some mechanism to clean up all builds besides the last one. --- .github/workflows/ci-bonsai-daily.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-bonsai-daily.yml b/.github/workflows/ci-bonsai-daily.yml index fa0a892a6b..4fbbc0def2 100644 --- a/.github/workflows/ci-bonsai-daily.yml +++ b/.github/workflows/ci-bonsai-daily.yml @@ -64,7 +64,10 @@ jobs: run: echo "version=$(cat VERSION)" >> $GITHUB_OUTPUT - name: Get current date id: date - run: echo "date=$(date +'%y%m%d')" >> $GITHUB_OUTPUT + # Include hours and minutes to release tag + # to avoid possibility of unstable repo's index.json + # pointing to the new file when index.json itself wasn't yet updated. + run: echo "date=$(date +'%y%m%d%H%M')" >> $GITHUB_OUTPUT - name: Compile run: | cd src/bonsai && make dist PLATFORM=${{ matrix.config.short_name }} PYVERSION=${{ matrix.pyver }}