Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-18 22:33:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sane error messages for unsupported items in geometry libs #8106

Browse Source
This commit is contained in:
Thomas Krijnen
2026-05-27 14:55:25 +02:00
parent 99d758a330
commit 0eedc7bdc2
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/AbstractKernel.h
+14 -6
View File
@@ -157,9 +157,13 @@ namespace {
template <> template <>
struct dispatch_conversion<ifcopenshell::geometry::taxonomy::type_by_kind::max> { struct dispatch_conversion<ifcopenshell::geometry::taxonomy::type_by_kind::max> {
static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* k, ifcopenshell::geometry::taxonomy::kinds, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) { static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* kernel, ifcopenshell::geometry::taxonomy::kinds, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) {
if (k->partial_success_is_success) { if (kernel->partial_success_is_success) {
logger::error("No conversion for " + std::to_string(item->kind())); std::string created_from;
if (item->instance) {
created_from = " (created from " + item->instance->declaration().name() + ")";
}
logger::error("No support for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library());
} }
return false; return false;
} }
@@ -179,9 +183,13 @@ namespace {
template <> template <>
struct dispatch_with_upgrade<ifcopenshell::geometry::taxonomy::upgrades::max> { struct dispatch_with_upgrade<ifcopenshell::geometry::taxonomy::upgrades::max> {
static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* k, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) { static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* kernel, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) {
if (k->partial_success_is_success) { if (kernel->partial_success_is_success) {
logger::error("No conversion with upgrade for " + std::to_string(item->kind())); std::string created_from;
if (item->instance) {
created_from = " (created from " + item->instance->declaration().name() + ")";
}
logger::error("No support (after considering item upgrade) for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library());
} }
return false; return false;
} }