From 0f6cc23c28b5b5135d97a69db2afd6eecd225dc6 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Wed, 6 Aug 2025 17:05:29 +0500 Subject: [PATCH] prop_with_search.enable_relating_type_suggestions - keep default to False To gradually introduce it when it's needed. --- src/bonsai/bonsai/bim/helper.py | 2 +- src/bonsai/bonsai/bim/module/covering/workspace.py | 8 +++++++- src/bonsai/bonsai/bim/module/drawing/workspace.py | 8 +++++++- src/bonsai/bonsai/bim/module/model/workspace.py | 1 + src/bonsai/bonsai/bim/module/type/ui.py | 8 +++++++- 5 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/bonsai/bonsai/bim/helper.py b/src/bonsai/bonsai/bim/helper.py index f7f0e52236..e631820cbf 100644 --- a/src/bonsai/bonsai/bim/helper.py +++ b/src/bonsai/bonsai/bim/helper.py @@ -361,7 +361,7 @@ def prop_with_search( should_click_ok: bool = False, original_operator_path: Optional[str] = None, *, - enable_relating_type_suggestions: bool = True, + enable_relating_type_suggestions: bool = False, search_threshold: int = 10, button_kwargs: Union[dict[str, Any], None] = None, **kwargs: Any, diff --git a/src/bonsai/bonsai/bim/module/covering/workspace.py b/src/bonsai/bonsai/bim/module/covering/workspace.py index e0b0195b83..1e19d9f42b 100644 --- a/src/bonsai/bonsai/bim/module/covering/workspace.py +++ b/src/bonsai/bonsai/bim/module/covering/workspace.py @@ -121,7 +121,13 @@ class CoveringToolUI: if AuthoringData.data["ifc_classes"]: row = cls.layout.row(align=True) row.label(text="", icon="FILE_3D") - prop_with_search(row, cls.props, "relating_type_id", text="") + prop_with_search( + row, + cls.props, + "relating_type_id", + text="", + enable_relating_type_suggestions=True, + ) row.operator("bim.launch_type_manager", icon=tool.Blender.TYPE_MANAGER_ICON, text="") else: row.label(text=f"No {AuthoringData.data['ifc_element_type']} Found", icon="ERROR") diff --git a/src/bonsai/bonsai/bim/module/drawing/workspace.py b/src/bonsai/bonsai/bim/module/drawing/workspace.py index e6970df7e4..8781e80758 100644 --- a/src/bonsai/bonsai/bim/module/drawing/workspace.py +++ b/src/bonsai/bonsai/bim/module/drawing/workspace.py @@ -238,7 +238,13 @@ class AnnotationToolUI: row = cls.layout.row(align=True) row.label(text="", icon="FILE_3D") - prop_with_search(row, cls.props, "relating_type_id", text="") + prop_with_search( + row, + cls.props, + "relating_type_id", + text="", + enable_relating_type_suggestions=True, + ) row.operator("bim.launch_annotation_type_manager", icon=tool.Blender.TYPE_MANAGER_ICON, text="") add_layout_hotkey_operator(cls.layout, "Add", "S_A", "Create a new annotation") diff --git a/src/bonsai/bonsai/bim/module/model/workspace.py b/src/bonsai/bonsai/bim/module/model/workspace.py index 58dea40d2d..5deb026829 100644 --- a/src/bonsai/bonsai/bim/module/model/workspace.py +++ b/src/bonsai/bonsai/bim/module/model/workspace.py @@ -662,6 +662,7 @@ class CreateObjectUI: text="", button_kwargs={"emboss": False}, emboss=True, + enable_relating_type_suggestions=True, ) # Limit width because names can get really long. row_.ui_units_x = 10.0 diff --git a/src/bonsai/bonsai/bim/module/type/ui.py b/src/bonsai/bonsai/bim/module/type/ui.py index 701dff465d..8434254b53 100644 --- a/src/bonsai/bonsai/bim/module/type/ui.py +++ b/src/bonsai/bonsai/bim/module/type/ui.py @@ -79,7 +79,13 @@ class BIM_PT_type(Panel): row.prop(props, "relating_type_class", text="") if type_prop.get_relating_type(None, context): - prop_with_search(row, props, "relating_type", text="") + prop_with_search( + row, + props, + "relating_type", + text="", + enable_relating_type_suggestions=True, + ) row.operator("bim.assign_type", icon="CHECKMARK", text="") row_object.prop(props, "relating_type_object", icon="COPYDOWN") else: