Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-12 14:33:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for null pointers returned by find_representation()

Browse Source
This commit is contained in:
Thomas Krijnen
2018-11-20 12:10:44 +01:00
parent 91290f43ca
commit 10ea9d700e
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomFunctions.cpp
+13 -1
View File
@@ -1818,9 +1818,15 @@ bool IfcGeom::Kernel::convert_layerset(const IfcSchema::IfcProduct* product, std
} }
IfcSchema::IfcRepresentation* body_representation = find_representation(product, "Body"); IfcSchema::IfcRepresentation* body_representation = find_representation(product, "Body");
IfcSchema::IfcRepresentation* axis_representation = find_representation(product, "Axis");
if (!body_representation) {
Logger::Warning("No body representation for product", product->entity);
return false;
}
if (product->is(IfcSchema::Type::IfcWall)) { if (product->is(IfcSchema::Type::IfcWall)) {
IfcSchema::IfcRepresentation* axis_representation = find_representation(product, "Axis");
if (!axis_representation) { if (!axis_representation) {
Logger::Message(Logger::LOG_WARNING, "No axis representation for:", product->entity); Logger::Message(Logger::LOG_WARNING, "No axis representation for:", product->entity);
return false; return false;
@@ -2190,10 +2196,16 @@ bool IfcGeom::Kernel::fold_layers(const IfcSchema::IfcWall* wall, const IfcRepre
gp_Trsf other; gp_Trsf other;
if (!convert(other_wall->ObjectPlacement(), other)) { if (!convert(other_wall->ObjectPlacement(), other)) {
Logger::Error("Failed to convert placement", other_wall->entity);
continue; continue;
} }
IfcSchema::IfcRepresentation* axis_representation = find_representation(other_wall, "Axis"); IfcSchema::IfcRepresentation* axis_representation = find_representation(other_wall, "Axis");
if (!axis_representation) {
Logger::Warning("Joined wall has no axis representation", other_wall->entity);
continue;
}
IfcRepresentationShapeItems axis_items; IfcRepresentationShapeItems axis_items;
{ {