Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-28 07:49:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bonsai: refuse class-mismatched type assignment

Browse Source 
Schema-illegal IfcDoor->IfcWallType pairings parse cleanly but propagate
into operators that fan out by type and eventually crash the wrapper.
Block the pairing at its source: API guard in ifcopenshell.api.type.
assign_type, per-object partition in BIM_OT_assign_type + DuplicateType,
new tool.Type.is_relating_type_compatible helper, AST forward-compat
guard. Files in the wild are still loaded unchanged.

Generated with the assistance of an AI coding tool.
This commit is contained in:
Gorgious56
2026-06-24 08:47:57 +02:00
parent 59383f5010
commit 10ee5aef4f
9 changed files with 416 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/test/tool/test_type.py
+42
View File
@@ -172,6 +172,48 @@ class TestHasMaterialUsage(NewFile):
assert subject.has_material_usage(element) is True
class TestIsRelatingTypeCompatible(NewFile):
def test_matched_pair_ifc4(self):
ifc = ifcopenshell.file()
door = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoor")
door_type = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoorType")
assert subject.is_relating_type_compatible(door, door_type) is True
def test_mismatched_pair_ifc4(self):
ifc = ifcopenshell.file()
door = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoor")
wall_type = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcWallType")
assert subject.is_relating_type_compatible(door, wall_type) is False
def test_legacy_style_pairing_allowed_in_ifc4(self):
ifc = ifcopenshell.file()
door = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoor")
door_style = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoorStyle")
assert subject.is_relating_type_compatible(door, door_style) is True
def test_legacy_style_pairing_refused_in_ifc4x3(self):
ifc = ifcopenshell.file(schema="IFC4X3")
door = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoor")
try:
door_style = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoorStyle")
except Exception:
# IfcDoorStyle was removed in IFC4X3 — exclusion holds trivially.
return
assert subject.is_relating_type_compatible(door, door_style) is False
def test_untypable_occurrence_returns_false(self):
ifc = ifcopenshell.file()
opening = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcOpeningElement")
any_type = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcDoorType")
assert subject.is_relating_type_compatible(opening, any_type) is False
def test_proxy_type_pairing(self):
ifc = ifcopenshell.file()
proxy = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcBuildingElementProxy")
proxy_type = ifcopenshell.api.root.create_entity(ifc, ifc_class="IfcBuildingElementProxyType")
assert subject.is_relating_type_compatible(proxy, proxy_type) is True
class TestRunGeometryAddRepresentation(NewFile):
def test_nothing(self):
pass