Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-26 18:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

IfcParse: don't let a malformed binary token abort the parser

Browse Source 
dispatch_token's Token_BINARY branch called TokenFunc::asBinary()
unguarded. A fuzzed file with a stray double-quote inside a numeric
list turns the next token into a 1-character Token_BINARY (e.g. a
lone '"'), which asBinary() rejects by throwing IfcException("Token
is not a valid binary sequence"). Nothing caught it, so it propagated
out of parse_context::construct and aborted the process instead of
producing a validation error.

Wrap the call in the same try/catch pattern already used a few lines
below for Token_ENUMERATION, logging a VAL error instead of crashing.
This commit is contained in:
Bruno Postle
2026-07-16 22:41:03 +01:00
parent 25441bd816
commit 1156a5512b
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcparse/IfcFile.cpp
+5 -1
View File
@@ -61,7 +61,11 @@ namespace {
template <typename Fn> template <typename Fn>
void dispatch_token(boost::optional<size_t> instance_id, int attribute_id, IfcParse::Token t, IfcParse::declaration* decl, Logger& logger, Fn fn) { void dispatch_token(boost::optional<size_t> instance_id, int attribute_id, IfcParse::Token t, IfcParse::declaration* decl, Logger& logger, Fn fn) {
if (t.type == IfcParse::Token_BINARY) { if (t.type == IfcParse::Token_BINARY) {
fn(IfcParse::TokenFunc::asBinary(t)); try {
fn(IfcParse::TokenFunc::asBinary(t));
} catch (IfcParse::IfcException& e) {
logger.Error("VAL", 20, "Invalid binary token at offset " + std::to_string(t.startPos));
}
} else if (IfcParse::TokenFunc::isBool(t)) { } else if (IfcParse::TokenFunc::isBool(t)) {
fn(IfcParse::TokenFunc::asBool(t)); fn(IfcParse::TokenFunc::asBool(t));
} else if (IfcParse::TokenFunc::isLogical(t)) { } else if (IfcParse::TokenFunc::isLogical(t)) {