Switched back to Polyhedron_3 for shapes. Should be checked.

src/ifcgeom/kernels/cgal/CgalConversionFunctions.cpp

@@ -23,7 +23,7 @@ void IfcGeom::CgalKernel::remove_duplicate_points_from_loop(cgal_wire_t& polygon
   }
 }
 
-CGAL::Nef_polyhedron_3<Kernel> IfcGeom::CgalKernel::create_nef_polyhedron(std::list<cgal_face_t> &face_list) {
+CGAL::Polyhedron_3<Kernel> IfcGeom::CgalKernel::create_polyhedron(std::list<cgal_face_t> &face_list) {
   
   // Naive creation
   CGAL::Polyhedron_3<Kernel> polyhedron = CGAL::Polyhedron_3<Kernel>();
@@ -34,35 +34,25 @@ CGAL::Nef_polyhedron_3<Kernel> IfcGeom::CgalKernel::create_nef_polyhedron(std::l
   //  std::cout << "Before: " << polyhedron.size_of_vertices() << " vertices and " << polyhedron.size_of_facets() << " facets" << std::endl;
   CGAL::Polygon_mesh_processing::stitch_borders(polyhedron);
   if (!polyhedron.is_valid()) {
-    std::cout << "create_nef_polyhedron: Polyhedron not valid!" << std::endl;
+    std::cout << "create_polyhedron: Polyhedron not valid!" << std::endl;
-//    std::ofstream fresult;
+    //    std::ofstream fresult;
-//    fresult.open("/Users/ken/Desktop/invalid.off");
+    //    fresult.open("/Users/ken/Desktop/invalid.off");
-//    fresult << polyhedron << std::endl;
+    //    fresult << polyhedron << std::endl;
-//    fresult.close();
+    //    fresult.close();
-    return CGAL::Nef_polyhedron_3<Kernel>();
+    return CGAL::Polyhedron_3<Kernel>();
-  } if (!polyhedron.is_closed()) {
+  } if (polyhedron.is_closed()) {
-//    std::ofstream fresult;
+    if (!CGAL::Polygon_mesh_processing::is_outward_oriented(polyhedron)) {
-//    fresult.open("/Users/ken/Desktop/open.off");
+      CGAL::Polygon_mesh_processing::reverse_face_orientations(polyhedron);
-//    fresult << polyhedron << std::endl;
+    }
-//    fresult.close();
-    CGAL::Nef_polyhedron_3<Kernel> mesh;
-    unsigned int current_face = 0;
-    for (auto &face: faces(polyhedron)) {
-      ++current_face;
-//      if (current_face%10 == 0) std::cout << current_face << "/" << polyhedron.size_of_facets() << std::endl;
-      std::list<Kernel::Point_3> points_in_face;
-      CGAL::Polyhedron_3<Kernel>::Halfedge_around_facet_const_circulator current_halfedge = face->facet_begin();
-      do {
-        points_in_face.push_back(current_halfedge->vertex()->point());
-        ++current_halfedge;
-      } while (current_halfedge != face->facet_begin());
-      mesh += CGAL::Nef_polyhedron_3<Kernel>(points_in_face.begin(), points_in_face.end());
-    } return mesh;
-  }
-  if (!CGAL::Polygon_mesh_processing::is_outward_oriented(polyhedron)) {
-    CGAL::Polygon_mesh_processing::reverse_face_orientations(polyhedron);
   }
+  
   //  std::cout << "After: " << polyhedron.size_of_vertices() << " vertices and " << polyhedron.size_of_facets() << " facets" << std::endl;
   
+  return polyhedron;
+}
+
+
+CGAL::Nef_polyhedron_3<Kernel> IfcGeom::CgalKernel::create_nef_polyhedron(std::list<cgal_face_t> &face_list) {
+  CGAL::Polyhedron_3<Kernel> polyhedron = create_polyhedron(face_list);
   return CGAL::Nef_polyhedron_3<Kernel>(polyhedron);
 }

src/ifcgeom/kernels/cgal/CgalConversionResult.cpp

@@ -5,41 +5,8 @@ void IfcGeom::CgalShape::Triangulate(const IfcGeom::IteratorSettings & settings,
   cgal_shape_t s = shape_;
   const cgal_placement_t& trsf = dynamic_cast<const CgalPlacement*>(place)->trsf();
   
-  std::cout << "Nef Model: " << s.number_of_facets() << " facets and " << s.number_of_vertices() << " vertices" << std::endl;
-  std::cout << "Simple: " << s.is_simple() << std::endl;
-  
-  CGAL::Polyhedron_3<Kernel> polyhedron;
-  if (s.is_simple()) s.convert_to_polyhedron(polyhedron);
-  else {
-    std::list<cgal_face_t> face_list;
-    face_list.push_back(cgal_face_t());
-    std::set<CGAL::Nef_polyhedron_3<Kernel>::Halffacet_const_handle> visited_halffacets;
-    for (CGAL::Nef_polyhedron_3<Kernel>::Halffacet_const_iterator current_halffacet = s.halffacets_begin();
-         current_halffacet != s.halffacets_end();
-         ++current_halffacet) {
-      if (visited_halffacets.count(current_halffacet->twin())) continue;
-      for (CGAL::Nef_polyhedron_3<Kernel>::Halffacet_cycle_const_iterator current_halffacet_cycle = current_halffacet->facet_cycles_begin();
-           current_halffacet_cycle != current_halffacet->facet_cycles_end();
-           ++current_halffacet_cycle) {
-        if (current_halffacet_cycle.is_shalfloop()) continue;
-        CGAL::Nef_polyhedron_3<Kernel>::SHalfedge_const_handle first_shalfedge = current_halffacet_cycle;
-        CGAL::Nef_polyhedron_3<Kernel>::SHalfedge_const_handle current_shalfedge = first_shalfedge;
-        if (!face_list.back().outer.empty()) face_list.push_back(cgal_face_t());
-        do {
-          face_list.back().outer.push_back(current_shalfedge->source()->center_vertex()->point());
-          current_shalfedge = current_shalfedge->next();
-        } while (current_shalfedge != first_shalfedge);
-      }
-    } if (face_list.back().outer.empty()) face_list.pop_back();
-    PolyhedronBuilder builder(&face_list);
-    polyhedron.delegate(builder);
-  }
-  
-  std::cout << "Polyhedron Model: " << polyhedron.size_of_facets() << " facets and " << polyhedron.size_of_vertices() << " vertices" << std::endl;
-  std::cout << "Valid: " << polyhedron.is_valid() << std::endl;
-  
   // Apply transformation
-  if (place != NULL) for (auto &vertex: vertices(polyhedron)) {
+  if (place != NULL) for (auto &vertex: vertices(s)) {
     vertex->point() = vertex->point().transform(trsf);
   }
   
@@ -53,7 +20,7 @@ void IfcGeom::CgalShape::Triangulate(const IfcGeom::IteratorSettings & settings,
   boost::associative_property_map<std::map<cgal_vertex_descriptor_t, Kernel::Vector_3>> vertex_normals_map(vertex_normals);
   std::map<cgal_face_descriptor_t, Kernel::Vector_3> face_normals;
   boost::associative_property_map<std::map<cgal_face_descriptor_t, Kernel::Vector_3>> face_normals_map(face_normals);
-  if (CGAL::Polygon_mesh_processing::triangulate_faces(polyhedron)) {
+  if (CGAL::Polygon_mesh_processing::triangulate_faces(s)) {
 //    std::cout << "Triangulated model: " << s.size_of_facets() << " facets and " << s.size_of_vertices() << " vertices" << std::endl;
   } else {
     Logger::Message(Logger::LOG_ERROR, "Failed to triangulate shape");
@@ -65,9 +32,9 @@ void IfcGeom::CgalShape::Triangulate(const IfcGeom::IteratorSettings & settings,
 //  fafter << s << std::endl;
 //  fafter.close();
 
-  CGAL::Polygon_mesh_processing::compute_normals(polyhedron, vertex_normals_map, face_normals_map);
+  CGAL::Polygon_mesh_processing::compute_normals(s, vertex_normals_map, face_normals_map);
   
-  for (auto &face: faces(polyhedron)) {
+  for (auto &face: faces(s)) {
     if (!face->is_triangle()) {
       std::cout << "Warning: non-triangular face!" << std::endl;
       continue;

src/ifcgeom/kernels/cgal/CgalIfcGeomPrimitives.cpp

@@ -127,7 +127,6 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcAxis2Placement3D* l, cgal_
 }
 
 bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcObjectPlacement* l, cgal_placement_t& trsf) {
-  // TODO: These macros don't work for the CGAL types. Need to check why.
   //  IN_CACHE(IfcObjectPlacement,l,cgal_placement_t,trsf)
   if ( ! l->is(IfcSchema::Type::IfcLocalPlacement) ) {
     Logger::Message(Logger::LOG_ERROR, "Unsupported IfcObjectPlacement:", l->entity);

src/ifcgeom/kernels/cgal/CgalIfcGeomShapes.cpp

@@ -50,7 +50,7 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcExtrudedAreaSolid *l, cgal
     top_face.outer.push_back(*vertex+height*dir);
   } face_list.push_back(top_face);
   
-  shape = create_nef_polyhedron(face_list);
+  CGAL::Nef_polyhedron_3<Kernel> nef_shape = create_nef_polyhedron(face_list);
   
   // Inner
   // TODO: Would be faster to triangulate top/bottom face template rather than use Nef polyhedra for subtraction
@@ -84,10 +84,11 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcExtrudedAreaSolid *l, cgal
       hole_top_face.outer.push_back(*vertex+height*dir);
     } face_list.push_back(hole_top_face);
     
-    shape -= create_nef_polyhedron(face_list);
+    nef_shape -= create_nef_polyhedron(face_list);
   }
   
-  shape.transform(trsf);
+  nef_shape.transform(trsf);
+  nef_shape.convert_to_polyhedron(shape);
   return true;
 }
 
@@ -116,7 +117,7 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcConnectedFaceSet* l, cgal_
     face_list.push_back(face);
   }
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
   return true;
 }
 
@@ -176,9 +177,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBlock* l, cgal_shape_t& sh
   cgal_placement_t trsf;
   IfcGeom::CgalKernel::convert(l->Position(),trsf);
 
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
-  shape.transform(trsf);
+  for (auto &vertex: vertices(shape)) vertex->point() = vertex->point().transform(trsf);
-  
   return true;
 }
 
@@ -233,8 +233,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
   
   const IfcSchema::IfcBooleanOperator::IfcBooleanOperator op = l->Operator();
   
-  if (!s1.is_simple()) {
+  if (!s1.is_valid()) {
-    Logger::Message(Logger::LOG_ERROR, "s1: Not simple Nef?", operand1->entity);
+    Logger::Message(Logger::LOG_ERROR, "s1: Not valid?", operand1->entity);
     return false;
   } else {
 //    std::ofstream f1;
@@ -247,8 +247,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
   
   bool is_plane = false;
   cgal_plane_t plane;
-  if (!s2.is_simple()) {
+  if (!s2.is_valid()) {
-    Logger::Message(Logger::LOG_ERROR, "s2: Not simple Nef?", operand2->entity);
+    Logger::Message(Logger::LOG_ERROR, "s2: Not valid?", operand2->entity);
     return false;
   } else if (is_halfspace) {
     //    std::cout << "s2: halfspace" << std::endl;
@@ -285,11 +285,11 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
   if (op == IfcSchema::IfcBooleanOperator::IfcBooleanOperator_DIFFERENCE) {
     
 //    std::cout << "Difference" << std::endl;
-    CGAL::Nef_polyhedron_3<Kernel> nef_result = s1;
+    CGAL::Nef_polyhedron_3<Kernel> nef_result(s1);
     if (is_halfspace) {
       if (is_plane) nef_result = nef_result.intersection(plane, CGAL::Nef_polyhedron_3<Kernel>::Intersection_mode::CLOSED_HALFSPACE);
     } else {
-      nef_result -= s2;
+      nef_result -= CGAL::Nef_polyhedron_3<Kernel>(s2);
     }
     if (!nef_result.is_simple()) {
       std::cout << "Not simple: " << nef_result.number_of_volumes() << " volumes" << std::endl;
@@ -301,13 +301,13 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
 //      fresult.open("/Users/ken/Desktop/result.off");
 //      fresult << result << std::endl;
 //      fresult.close();
-    } shape = nef_result;
+    } nef_result.convert_to_polyhedron(shape);
     return true;
     
   } else if (op == IfcSchema::IfcBooleanOperator::IfcBooleanOperator_UNION) {
 
 //    std::cout << "Union" << std::endl;
-    CGAL::Nef_polyhedron_3<Kernel> nef_result = s1+s2;
+    CGAL::Nef_polyhedron_3<Kernel> nef_result = CGAL::Nef_polyhedron_3<Kernel>(s1)+CGAL::Nef_polyhedron_3<Kernel>(s2);
     if (!nef_result.is_simple()) {
       std::cout << "Not simple: " << nef_result.number_of_volumes() << " volumes" << std::endl;
       return false;
@@ -318,13 +318,13 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
 //      fresult.open("/Users/ken/Desktop/result.off");
 //      fresult << result << std::endl;
 //      fresult.close();
-    } shape = nef_result;
+    } nef_result.convert_to_polyhedron(shape);
     return true;
     
   } else if (op == IfcSchema::IfcBooleanOperator::IfcBooleanOperator_INTERSECTION) {
 
 //    std::cout << "Intersection" << std::endl;
-    CGAL::Nef_polyhedron_3<Kernel> nef_result = s1*s2;
+    CGAL::Nef_polyhedron_3<Kernel> nef_result = CGAL::Nef_polyhedron_3<Kernel>(s1)*CGAL::Nef_polyhedron_3<Kernel>(s2);
     if (!nef_result.is_simple()) {
       std::cout << "Not simple: " << nef_result.number_of_volumes() << " volumes" << std::endl;
       return false;
@@ -335,7 +335,7 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcBooleanResult* l, cgal_sha
 //      fresult.open("/Users/ken/Desktop/result.off");
 //      fresult << result << std::endl;
 //      fresult.close();
-    } shape = nef_result;
+    } nef_result.convert_to_polyhedron(shape);
     return true;
   } return false;
 }
@@ -512,8 +512,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcSphere* l, cgal_shape_t& s
   cgal_placement_t trsf;
   IfcGeom::CgalKernel::convert(l->Position(),trsf);
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
-  shape.transform(trsf);
+  for (auto &vertex: vertices(shape)) vertex->point() = vertex->point().transform(trsf);
   return true;
 }
 
@@ -555,8 +555,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcRectangularPyramid* l, cga
   cgal_placement_t trsf;
   IfcGeom::CgalKernel::convert(l->Position(),trsf);
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
-  shape.transform(trsf);
+  for (auto &vertex: vertices(shape)) vertex->point() = vertex->point().transform(trsf);
   return true;
 }
 
@@ -597,8 +597,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcRightCircularCylinder* l,
   cgal_placement_t trsf;
   IfcGeom::CgalKernel::convert(l->Position(),trsf);
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
-  shape.transform(trsf);
+  for (auto &vertex: vertices(shape)) vertex->point() = vertex->point().transform(trsf);
   return true;
 }
 
@@ -631,8 +631,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcRightCircularCone* l, cgal
   cgal_placement_t trsf;
   IfcGeom::CgalKernel::convert(l->Position(),trsf);
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
-  shape.transform(trsf);
+  for (auto &vertex: vertices(shape)) vertex->point() = vertex->point().transform(trsf);
   return true;
 }
 
@@ -682,7 +682,7 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcTriangulatedFaceSet* l, cg
     face_list.back().outer.push_back(c);
   }
   
-  shape = create_nef_polyhedron(face_list);
+  shape = create_polyhedron(face_list);
   return true;
 }
 #endif
@@ -701,8 +701,8 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcHalfSpaceSolid* l, cgal_sh
 //  const gp_Pnt pnt = pln.Location().Translated( l->AgreementFlag() ? -pln.Axis().Direction() : pln.Axis().Direction());
 //  shape = BRepPrimAPI_MakeHalfSpace(BRepBuilderAPI_MakeFace(pln),pnt).Solid();
   
-  shape = CGAL::Nef_polyhedron_3<Kernel>();
+  shape = CGAL::Polyhedron_3<Kernel>();
-  // TODO: We return an empty Nef polyhedron for now and handle halfspace differences in IfcBooleanResult. The other option would be to switch to an extended kernel.
+  // TODO: We need to do something for now. Find a better solution later (abstract shape class?)
 //  shape = CGAL::Nef_polyhedron_3<Kernel>(pln);
   return true;
 }

src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp

@@ -63,6 +63,7 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcShellBasedSurfaceModel* l,
 
 bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcManifoldSolidBrep* l, ConversionResults& shape) {
   cgal_shape_t s;
+  CGAL::Nef_polyhedron_3<Kernel> nef_s(s);
   const SurfaceStyle* collective_style = get_style(l);
   if (convert_shape(l->Outer(),s) ) {
     const SurfaceStyle* indiv_style = get_style(l->Outer());
@@ -79,14 +80,16 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcManifoldSolidBrep* l, Conv
     
     for (IfcSchema::IfcClosedShell::list::it it = voids->begin(); it != voids->end(); ++it) {
       cgal_shape_t s2;
+      CGAL::Nef_polyhedron_3<Kernel> nef_s2(s2);
       // TODO: This looks weird. Aren't we removing the outer shell again and again?
       // Maybe it should be
       // if (convert_shape(*it, s2)) {
       if (convert_shape(l->Outer(), s2)) {
-        s -= s2;
+        nef_s -= nef_s2;
       }
     }
     
+    nef_s.convert_to_polyhedron(s);
     shape.push_back(ConversionResult(new CgalShape(s), indiv_style ? indiv_style : collective_style));
     return true;
   }

src/ifcgeom/kernels/cgal/CgalKernel.cpp

@@ -250,7 +250,7 @@ bool IfcGeom::CgalKernel::convert_openings(const IfcSchema::IfcProduct* entity,
         }
         gtrsf = gtrsf * opening_trsf;
         cgal_shape_t opening_shape(((CgalShape*)opening_shapes[i].Shape())->shape());
-        opening_shape.transform(gtrsf);
+        for (auto &vertex: vertices(opening_shape)) vertex->point() = vertex->point().transform(gtrsf);
         opening_shapelist.push_back(opening_shape);
 
 //        std::cout << "gtrsf" << std::endl;
@@ -270,10 +270,11 @@ bool IfcGeom::CgalKernel::convert_openings(const IfcSchema::IfcProduct* entity,
     cgal_shape_t entity_shape(entity_shape_unlocated);
     if (it3->Placement()) {
       const cgal_placement_t& entity_shape_gtrsf = *(CgalPlacement*)it3->Placement();
-      entity_shape.transform(entity_shape_gtrsf);
+      for (auto &vertex: vertices(entity_shape)) vertex->point() = vertex->point().transform(entity_shape_gtrsf);
     }
     
     cgal_shape_t brep_cut_result(entity_shape);
+    CGAL::Nef_polyhedron_3<Kernel> nef_brep_cut_result(brep_cut_result);
     
     for (auto &opening: opening_shapelist) {
       
@@ -289,7 +290,8 @@ bool IfcGeom::CgalKernel::convert_openings(const IfcSchema::IfcProduct* entity,
 //      fresult << polyhedron << std::endl;
 //      fresult.close();
       
-      brep_cut_result -= opening;
+      CGAL::Nef_polyhedron_3<Kernel> nef_opening(opening);
+      nef_brep_cut_result -= nef_opening;
       
 //      brep_cut_result.convert_to_polyhedron(polyhedron);
 //      fresult.open("/Users/ken/Desktop/after.off");
@@ -298,6 +300,7 @@ bool IfcGeom::CgalKernel::convert_openings(const IfcSchema::IfcProduct* entity,
     }
     
     if (brep_cut_result.is_valid()) {
+      nef_brep_cut_result.convert_to_Polyhedron(brep_cut_result);
       cut_shapes.push_back(IfcGeom::ConversionResult(new CgalShape(brep_cut_result), &it3->Style()));
     } else {
       // Apparently processing the boolean operation failed or resulted in an invalid result

src/ifcgeom/kernels/cgal/CgalKernel.h

@@ -64,7 +64,7 @@ struct cgal_face_t {
   std::vector<cgal_wire_t> inner;
 };
 
-typedef CGAL::Nef_polyhedron_3<Kernel> cgal_shape_t;
+typedef CGAL::Polyhedron_3<Kernel> cgal_shape_t;
 typedef boost::graph_traits<CGAL::Polyhedron_3<Kernel>>::vertex_descriptor cgal_vertex_descriptor_t;
 typedef boost::graph_traits<CGAL::Polyhedron_3<Kernel>>::face_descriptor cgal_face_descriptor_t;
 
@@ -140,6 +140,7 @@ namespace IfcGeom {
 
     bool convert_openings(const IfcSchema::IfcProduct* entity, const IfcSchema::IfcRelVoidsElement::list::ptr& openings, const ConversionResults& entity_shapes, const cgal_placement_t& entity_trsf, ConversionResults& cut_shapes);
     
+    CGAL::Polyhedron_3<Kernel> create_polyhedron(std::list<cgal_face_t> &face_list);
     CGAL::Nef_polyhedron_3<Kernel> create_nef_polyhedron(std::list<cgal_face_t> &face_list);
 
 		void purge_cache() {