Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-20 04:04:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add SVG edge classification on/off + render settings

Browse Source 
Add svg-use-edge-classification (default off, preserving today's
linework), svg-render-crease-edges, and svg-render-sharp-edges
settings, gating the existing 5-class classification feature so it
can be disabled entirely (falling back to the pre-classification
whole-shape output) or have individual classes suppressed.

Also fixes a bug uncovered while wiring this into Bonsai: ready(),
where geometry_settings() actually gets read into the serializer,
was only ever invoked explicitly by IfcConvert's CLI driver and
isn't exposed to Python. Every Svg* setting -- including the three
from previous rounds -- silently stayed at its hardcoded constructor
default when the serializer was constructed directly through the
Python bindings, as Bonsai does. Fixed by calling ready() from
SvgSerializer's own constructor, safe since it only reads
geometry_settings() with no other side effects, and settings are
always finalized before construction in every call path.

Generated with the assistance of an AI coding tool.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Stephen Boddy
2026-07-16 15:29:22 +01:00
parent 2ac92f01e4
commit 183e4c47f7
4 changed files with 64 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/serializers/SvgSerializer.h
+17 -1
View File
@@ -600,6 +600,9 @@ protected:
double svg_ridge_angle_min_deg_;
double svg_valley_angle_min_deg_;
bool svg_emit_flush_edges_;
bool svg_use_edge_classification_;
bool svg_render_crease_edges_;
bool svg_render_sharp_edges_;
IfcParse::IfcFile* file;
const IfcUtil::IfcBaseEntity* storey_;
@@ -657,6 +660,9 @@ public:
, svg_ridge_angle_min_deg_(45.)
, svg_valley_angle_min_deg_(12.)
, svg_emit_flush_edges_(false)
, svg_use_edge_classification_(false)
, svg_render_crease_edges_(true)
, svg_render_sharp_edges_(true)
, file(0)
, storey_(0)
, xcoords_begin(0)
@@ -665,7 +671,17 @@ public:
, hlr(nullptr)
, namespace_prefix_("data-")
, subtraction_settings_(ON_SLABS_AT_FLOORPLANS)
{}
{
// ready() only reads geometry_settings() (already valid at this point, since the base
// WriteOnlyGeometrySerializer initializer above has run) and has no other side effects,
// so it's safe to call here. This is needed because ready() is otherwise only invoked
// explicitly by IfcConvert.cpp's CLI driver -- callers that construct this serializer
// directly via the Python bindings (e.g. Bonsai's drawing generation, which never calls
// a ready()-equivalent because it isn't exposed via SWIG) would otherwise silently keep
// every settings::Svg* member at its hardcoded constructor default forever, regardless
// of what ifcopenshell.geom.settings().set(...) was actually configured to.
ready();
}
void addXCoordinate(const boost::shared_ptr<util::string_buffer::float_item>& fi) { xcoords.push_back(fi); }
void addYCoordinate(const boost::shared_ptr<util::string_buffer::float_item>& fi) { ycoords.push_back(fi); }
void addSizeComponent(const boost::shared_ptr<util::string_buffer::float_item>& fi) { radii.push_back(fi); }