Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-23 17:36:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where subelement coordinates were incorrectly calculated in non SI units

Browse Source
This commit is contained in:
Dion Moult
2021-11-17 16:22:23 +11:00
parent ddb8abff0f
commit 18719c16df
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/edit_object_placement.py
+1 -1
View File
@@ -79,7 +79,7 @@ class Usecase:
for referenced_placement in placement.ReferencedByPlacements: for referenced_placement in placement.ReferencedByPlacements:
matrix = ifcopenshell.util.placement.get_local_placement(referenced_placement) matrix = ifcopenshell.util.placement.get_local_placement(referenced_placement)
for obj in referenced_placement.PlacesObject: for obj in referenced_placement.PlacesObject:
results.append({"product": obj, "matrix": matrix, "is_si": self.settings["is_si"], "should_transform_children": False}) results.append({"product": obj, "matrix": matrix, "is_si": False, "should_transform_children": False})
results.extend(self.get_children_settings(referenced_placement)) results.extend(self.get_children_settings(referenced_placement))
return results return results
src/ifcopenshell-python/test/api/geometry/test_edit_object_placement.py
+43
View File
@@ -367,3 +367,46 @@ class TestEditObjectPlacement(test.bootstrap.IFC4):
ifcopenshell.util.placement.get_local_placement(subelement.ObjectPlacement), shifted_submatrix ifcopenshell.util.placement.get_local_placement(subelement.ObjectPlacement), shifted_submatrix
) )
assert subelement.ObjectPlacement.PlacementRelTo == element.ObjectPlacement assert subelement.ObjectPlacement.PlacementRelTo == element.ObjectPlacement
def test_changing_placements_with_children_using_non_si_units(self):
ifcopenshell.api.run("root.create_entity", self.file, ifc_class="IfcProject")
ifcopenshell.api.run("unit.assign_unit", self.file)
element = ifcopenshell.api.run("root.create_entity", self.file, ifc_class="IfcBuilding")
subelement = ifcopenshell.api.run("root.create_entity", self.file, ifc_class="IfcWall")
matrix = numpy.array(
(
(1.0, 0.0, 0.0, 1000.0),
(0.0, 1.0, 0.0, 1000.0),
(0.0, 0.0, 1.0, 1000.0),
(0.0, 0.0, 0.0, 1.0),
)
)
matrix_si = numpy.array(
(
(1.0, 0.0, 0.0, 1.0),
(0.0, 1.0, 0.0, 1.0),
(0.0, 0.0, 1.0, 1.0),
(0.0, 0.0, 0.0, 1.0),
)
)
submatrix = numpy.array(
(
(1.0, 0.0, 0.0, 1000.0),
(0.0, 1.0, 0.0, 2000.0),
(0.0, 0.0, 1.0, 3000.0),
(0.0, 0.0, 0.0, 1.0),
)
)
ifcopenshell.api.run("spatial.assign_container", self.file, product=subelement, relating_structure=element)
ifcopenshell.api.run(
"geometry.edit_object_placement", self.file, product=element, matrix=matrix.copy(), is_si=False
)
ifcopenshell.api.run(
"geometry.edit_object_placement", self.file, product=subelement, matrix=submatrix.copy(), is_si=False
)
ifcopenshell.api.run(
"geometry.edit_object_placement", self.file, product=element, matrix=matrix_si.copy(), is_si=True
)
assert numpy.array_equal(ifcopenshell.util.placement.get_local_placement(element.ObjectPlacement), matrix)
assert numpy.array_equal(ifcopenshell.util.placement.get_local_placement(subelement.ObjectPlacement), submatrix)
assert subelement.ObjectPlacement.PlacementRelTo == element.ObjectPlacement