From 1d0ee61ba7cd983942c489f1bd01c5a19f3e90dc Mon Sep 17 00:00:00 2001
From: Ziad-I <68874104+Ziad-I@users.noreply.github.com>
Date: Sat, 10 Aug 2024 22:38:54 +0300
Subject: [PATCH] fix dependency display bug

dependency was not being displayed correctly due to calling draw on Gantt before appending it to the DOM, I think?
---
 src/bonsai/bonsai/bim/data/webui/static/js/gantt.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/bonsai/bonsai/bim/data/webui/static/js/gantt.js b/src/bonsai/bonsai/bim/data/webui/static/js/gantt.js
index 5481a6d6db..df48673c71 100644
--- a/src/bonsai/bonsai/bim/data/webui/static/js/gantt.js
+++ b/src/bonsai/bonsai/bim/data/webui/static/js/gantt.js
@@ -164,6 +164,7 @@ function handleDefaultData(data) {
 }
 
 // Function to add a new gantt with data and filename
+
 function addGanttElement(blenderId, tasks, workSched, filename) {
   function createWorkSchedDiv(blenderId, workSched) {
     const workSchedDiv = $("<div></div>").attr("id", "workSched" + blenderId);
@@ -213,7 +214,7 @@ function addGanttElement(blenderId, tasks, workSched, filename) {
     return ganttInfoDiv;
   }
 
-  function createGantt(blenderId, tasks) {
+  function createGantt(blenderId) {
     const ganttDiv = $("<div></div>")
       .addClass("gantt-chart")
       .attr("id", "gantt-" + blenderId);
@@ -257,7 +258,6 @@ function addGanttElement(blenderId, tasks, workSched, filename) {
 
     JSGantt.addJSONTask(g, tasks);
     g.setEditable(true);
-    g.Draw();
 
     connectedClients[blenderId]["gantt"] = g;
 
@@ -345,6 +345,11 @@ function addGanttElement(blenderId, tasks, workSched, filename) {
   ganttContainer.append(printButton);
 
   $("#container").append(ganttContainer);
+
+  // have to  call draw after appening the containers to the DOM
+  // otherwise the dependencies will not be displayed properly
+  const g = connectedClients[blenderId].gantt;
+  g.Draw();
 }
 
 // Function to update gantt and filename