Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 23:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

ifcviewer: add incremental orbit/pan/zoom to ViewportCore (#85)

Browse Source 
The orbit navigation math lived in the Qt ViewportWindow, operating on
ViewportCore's camera fields through references. That left the web host
with no way to drive the camera — orbit/pan/zoom were Qt-only.

Lift the three pixel-delta moves into ViewportCore as orbitBy / panBy /
dollyBy so every host (Qt desktop + web) shares one implementation and
the math can't drift between platforms. panBy takes the viewport height
as a parameter (the one Qt coupling: pan's world-units-per-pixel needs
it) so the core stays toolkit-free.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Dion Moult
2026-06-29 10:49:54 +10:00
parent e8a6d2a92f
commit 1d13b05acf
2 changed files with 67 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcviewer/ViewportCore.h
+20
View File
@@ -184,6 +184,26 @@ public:
void setCamera(float tx, float ty, float tz,
float dist, float yaw_deg, float pitch_deg);
void setStandardView(float yaw_deg, float pitch_deg);
// ---- Incremental orbit navigation ---------------------------------------
//
// Pixel-delta camera moves, shared by every host (Qt desktop + web).
// Hosts translate raw pointer/wheel events into these calls and own
// their own UI concerns (drag promotion, pivot indicator, cursor
// capture); the orbit math lives here so it can't drift between
// platforms. Each schedules a frame via the host.
//
// orbitBy: drag-right yaws the world right (yaw -= dx), drag-down
// tilts the camera up (pitch += dy). 0.4 deg/px matches GL.
// panBy: shifts the target in the camera's screen plane; world
// units/pixel track the frustum height at the pivot so the
// feel is zoom-independent. Needs the viewport height.
// dollyBy: each wheel notch zooms ~10% (distance *= 0.9^notches);
// positive notches zoom in.
void orbitBy(float dx_px, float dy_px);
void panBy(float dx_px, float dy_px, int viewport_height_px);
void dollyBy(float notches);
void toggleProjection();
bool projectionOrtho() const { return projection_ortho_; }
std::string cameraString() const;