From 1d1e051e0f81fe2a327c74b62f1f5e7251d2f842 Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Tue, 21 Sep 2021 10:33:03 +1000 Subject: [PATCH] Fix #1709. --- src/blenderbim/Makefile | 2 +- src/ifcopenshell-python/ifcopenshell/file.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/blenderbim/Makefile b/src/blenderbim/Makefile index 414de55bb9..c0d6587d2b 100644 --- a/src/blenderbim/Makefile +++ b/src/blenderbim/Makefile @@ -93,7 +93,7 @@ endif cp -r blenderbim/* dist/blenderbim/ # Provides IfcOpenShell Python functionality - cd dist/working && wget https://s3.amazonaws.com/ifcopenshell-builds/ifcblender-python-$(PYNUMBER)-v0.6.0-2f3c79a-$(PLATFORM)64.zip + cd dist/working && wget https://s3.amazonaws.com/ifcopenshell-builds/ifcblender-python-$(PYNUMBER)-v0.6.0-721fe47-$(PLATFORM)64.zip cd dist/working && unzip ifcblender* cp -r dist/working/io_import_scene_ifc/ifcopenshell dist/blenderbim/libs/site/packages/ diff --git a/src/ifcopenshell-python/ifcopenshell/file.py b/src/ifcopenshell-python/ifcopenshell/file.py index dd8fe394c9..a96c5c7687 100644 --- a/src/ifcopenshell-python/ifcopenshell/file.py +++ b/src/ifcopenshell-python/ifcopenshell/file.py @@ -332,8 +332,7 @@ class file(object): If the entity already exists, it is not re-added.""" if self.transaction: - # TODO confirm this method of tracking added elements and use MaxId directly instead of FreshId - max_id = self.wrapped_data.FreshId() + max_id = self.wrapped_data.getMaxId() inst.wrapped_data.this.disown() result = entity_instance(self.wrapped_data.add(inst.wrapped_data, -1 if _id is None else _id), self) if self.transaction: