From 232e415c877a28d8c14052294a91d523fab64a16 Mon Sep 17 00:00:00 2001
From: Andrej730 <azhilenkov@gmail.com>
Date: Wed, 5 Apr 2023 12:36:42 +0500
Subject: [PATCH] Background for Ifc Text annotations in SVG

Added option to fill background of Ifc Text annotation with white color.

To make it work need to add "fill-bg" class to EPset_Annotation - https://i.imgur.com/ig2EhkQ.png.

Result - https://i.imgur.com/mq4hzAM.png
---
 .../blenderbim/bim/data/templates/markers.svg |  8 ++++++
 .../bim/module/drawing/svgwriter.py           | 27 ++++++++++++++-----
 2 files changed, 29 insertions(+), 6 deletions(-)

diff --git a/src/blenderbim/blenderbim/bim/data/templates/markers.svg b/src/blenderbim/blenderbim/bim/data/templates/markers.svg
index cff4a43af3..28ac7f2d5b 100644
--- a/src/blenderbim/blenderbim/bim/data/templates/markers.svg
+++ b/src/blenderbim/blenderbim/bim/data/templates/markers.svg
@@ -96,4 +96,12 @@
             <path d="M 7.5 10 L 10 0 L 15 10" class="annotation" style="stroke-width:1; fill: white;" />
         </g>
     </marker>
+    <filter x="0" y="0" width="1" height="1" id="fill-background">
+      <feFlood flood-color="white" result="bg" />
+      <feMerge>
+        <feMergeNode in="bg"/>
+        <feMergeNode in="SourceGraphic"/>
+      </feMerge>
+    </filter>
+
 </svg>
diff --git a/src/blenderbim/blenderbim/bim/module/drawing/svgwriter.py b/src/blenderbim/blenderbim/bim/module/drawing/svgwriter.py
index c9a0cbc17c..56263c6e93 100644
--- a/src/blenderbim/blenderbim/bim/module/drawing/svgwriter.py
+++ b/src/blenderbim/blenderbim/bim/module/drawing/svgwriter.py
@@ -68,7 +68,7 @@ class SvgWriter:
         self.related_paths = None
 
     def create_blank_svg(self, output_path):
-        self.define_related_paths() # making sure all paths are defined
+        self.define_related_paths()  # making sure all paths are defined
         self.calculate_scale()
         self.svg = svgwrite.Drawing(
             output_path,
@@ -662,7 +662,8 @@ class SvgWriter:
         )
 
         transform = "rotate({}, {}, {})".format(angle, *text_position_svg)
-        classes_str = " ".join(self.get_attribute_classes(text_obj))
+        classes = self.get_attribute_classes(text_obj)
+        classes_str = " ".join(classes)
 
         symbol = tool.Drawing.get_annotation_symbol(element)
         template_text_fields = []
@@ -731,12 +732,26 @@ class SvgWriter:
             )
             self.svg.add(text_tag)
 
-            for line_number, text_line in enumerate(text.replace("\\n", "\n").split("\n")):
+            tspans = []
+            text_lines = text.replace("\\n", "\n").split("\n")
+
+            # adding fill background tspan
+            # tspans and text doesn't support setting up "background-color"
+            # so we add a filter, we do it in separate span because otherwise it will produce blurry image
+            # adding just 1 tspan seems to work
+            if "fill-bg" in classes:
+                tspan = self.svg.tspan(
+                    text_lines[0], class_=classes_str, insert=text_position_svg, filter="url(#fill-background)"
+                )
+                text_tag.add(tspan)
+
+            for line_number, text_line in enumerate(text_lines):
                 # position has to be inserted at tspan to avoid x offset between tspans
-                t_span = self.svg.tspan(text_line, class_=classes_str, insert=text_position_svg)
+                tspan = self.svg.tspan(text_line, class_=classes_str, insert=text_position_svg)
                 # doing it here and not in tspan constructor because constructor adds unnecessary spaces
-                t_span.update({"dy": f"{line_number}em"})
-                text_tag.add(t_span)
+                tspan.update({"dy": f"{line_number}em"})
+                tspans.append(tspan)
+                text_tag.add(tspan)
 
     def draw_break_annotations(self, obj):
         x_offset = self.raw_width / 2