Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-17 14:02:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ci: test_get_class_relations calls wrong bSDD client method

Browse Source 
test_get_class_relations asserted on a "classRelations" key but called
client.get_class_properties() (endpoint Class/Properties/v1), whose
response never contains classRelations, so the test failed every run.
The Class/Relations/v1 endpoint is exposed by client.get_class_relations()
(with the same get_reverse_relations positional the test already passes),
which returns the classRelations payload the assertion expects.

Verified live against the bSDD API: the corrected call passes.

This change was made with the assistance of an AI tool.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Petru Conduraru
2026-07-12 21:33:52 +03:00
parent 980988f208
commit 29fb417f09
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bsdd/tests/test_bsdd.py
+1 -1
View File
@@ -39,7 +39,7 @@ def test_get_class():
def test_get_class_relations(): def test_get_class_relations():
uri_light_fixture = next(l for l in get_ifc_classes()["classes"] if "IfcLightFixture" == l["code"])["uri"] uri_light_fixture = next(l for l in get_ifc_classes()["classes"] if "IfcLightFixture" == l["code"])["uri"]
ifc4x3_light_fixture_relations = client.get_class_properties(uri_light_fixture, True) ifc4x3_light_fixture_relations = client.get_class_relations(uri_light_fixture, True)
assert "Electrical unit for light-line system" and "Tubelight system" in [ assert "Electrical unit for light-line system" and "Tubelight system" in [
r["className"] for r in ifc4x3_light_fixture_relations["classRelations"] r["className"] for r in ifc4x3_light_fixture_relations["classRelations"]
] ]