Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-16 21:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't log 'no op defined' for failed conversions

Browse Source
This commit is contained in:
Thomas Krijnen
2024-06-11 20:09:27 +02:00
parent dae7d86dad
commit 2a5e42e359
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/mapping/bind_convert_impl.i
+1
View File
@@ -4,6 +4,7 @@
#define BIND(T) \ #define BIND(T) \
if (!item && inst->as<IfcSchema::T>()) { \ if (!item && inst->as<IfcSchema::T>()) { \
matched = true; \
try { \ try { \
item = map_impl(inst->as<IfcSchema::T>()); \ item = map_impl(inst->as<IfcSchema::T>()); \
if (item != nullptr) { \ if (item != nullptr) { \
src/ifcgeom/mapping/mapping.cpp
+7 -4
View File
@@ -547,12 +547,15 @@ taxonomy::ptr mapping::map(const IfcBaseInterface* inst) {
// of if-statements and whether a switch on e.g inst->declaration()->index_in_schema() // of if-statements and whether a switch on e.g inst->declaration()->index_in_schema()
// isn't more efficient (which would disable inheritance though). // isn't more efficient (which would disable inheritance though).
bool matched = false;
#include "bind_convert_impl.i" #include "bind_convert_impl.i"
if (use_caching_ && item) { if (item) {
cache_.insert({ iden, item }); if (use_caching_) {
} cache_.insert({ iden, item });
else { }
} else if (!matched) {
Logger::Message(Logger::LOG_ERROR, "No operation defined for:", inst); Logger::Message(Logger::LOG_ERROR, "No operation defined for:", inst);
} }
return item; return item;