Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-25 17:57:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #1124. Fix example and document quirk to prevent memory related bug.

Browse Source
This commit is contained in:
Dion Moult
2021-08-04 11:45:56 +10:00
parent 5cf07a910e
commit 2c5442accc
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/geom/main.py
+7 -1
View File
@@ -184,6 +184,9 @@ def create_shape(settings, inst, repr=None):
or or
Return an OpenCASCADE BRep if settings.USE_PYTHON_OPENCASCADE == True Return an OpenCASCADE BRep if settings.USE_PYTHON_OPENCASCADE == True
Note that in Python, you must store a reference to the element returned by this function to prevent garbage
collection when you access its children. See #1124.
example: example:
settings = ifcopenshell.geom.settings() settings = ifcopenshell.geom.settings()
@@ -195,9 +198,12 @@ def create_shape(settings, inst, repr=None):
for i, product in enumerate(products): for i, product in enumerate(products):
if product.Representation is not None: if product.Representation is not None:
try: try:
shape = geom.create_shape(settings, inst=product).geometry created_shape = geom.create_shape(settings, inst=product)
shape = created_shape.geometry # see #1124
shape_gpXYZ = shape.Location().Transformation().TranslationPart() # These are methods of the TopoDS_Shape class from pythonOCC shape_gpXYZ = shape.Location().Transformation().TranslationPart() # These are methods of the TopoDS_Shape class from pythonOCC
print(shape_gpXYZ.X(), shape_gpXYZ.Y(), shape_gpXYZ.Z()) # These are methods of the gpXYZ class from pythonOCC print(shape_gpXYZ.X(), shape_gpXYZ.Y(), shape_gpXYZ.Z()) # These are methods of the gpXYZ class from pythonOCC
except:
print("Shape creation failed")
""" """
return wrap_shape_creation( return wrap_shape_creation(
settings, settings,