Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 09:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(selector): round() should not crash on non-numeric values (#6776)

Browse Source 
FormatTransformer.round() called Decimal() directly on the input value,
which raises decimal.InvalidOperation when the value is a non-numeric
string (a text property, or a value carrying a unit suffix like "12.5 m").
In a spreadsheet export this crashed the entire operation as soon as one
element carried such a value.

Now round() catches InvalidOperation and returns the value unchanged, the
same graceful-fallback convention used by add(). Numeric rounding is
unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Petru Conduraru
2026-07-09 13:24:28 +03:00
committed by Dion Moult
parent 6b3cc54afc
commit 2eea7728d2
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/test/util/test_selector.py
+3
View File
@@ -55,6 +55,9 @@ class TestFormat(test.bootstrap.IFC4):
assert subject.format("round(123, 5)") == "125"
assert subject.format('round("123", 5)') == "125"
assert subject.format("round(-123, 5)") == "-125"
# Non-numeric values must pass through unchanged instead of crashing (#6776).
assert subject.format('round("Level 1", 0.01)') == "Level 1"
assert subject.format('round("12.5 m", 0.01)') == "12.5 m"
assert subject.format("int(123.123)") == "123"
assert subject.format("int(123)") == "123"
assert subject.format("number(123)") == "123"