From 32f5c459c1741e8509af23e165401bfca718a111 Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Wed, 22 Sep 2021 21:27:53 +1000 Subject: [PATCH] Fixes from code review. --- src/ifcgeom/IfcGeomShapes.cpp | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/ifcgeom/IfcGeomShapes.cpp b/src/ifcgeom/IfcGeomShapes.cpp index 446404aa77..1f8d5d9b06 100644 --- a/src/ifcgeom/IfcGeomShapes.cpp +++ b/src/ifcgeom/IfcGeomShapes.cpp @@ -952,19 +952,11 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcBoundingBox* l, TopoDS_Shape& const double dy = l->YDim() * getValue(GV_LENGTH_UNIT); const double dz = l->ZDim() * getValue(GV_LENGTH_UNIT); - BRepPrimAPI_MakeBox builder(dx, dy, dz); gp_Pnt corner; IfcGeom::Kernel::convert(l->Corner(), corner); + BRepPrimAPI_MakeBox builder(corner, dx, dy, dz); - gp_Trsf trsf; - gp_Dir axis1 (1.,0.,0.); - gp_Dir axis3 (0.,0.,1.); - gp_Ax3 ax3 (corner, axis3, axis1); - trsf.SetTransformation(ax3); - trsf.Invert(); - - // IfcBoundingBox.Corner has unit scale factor - shape = builder.Solid().Moved(trsf); + shape = builder.Solid(); return true; }