From 34e2ff31bbcaee059839843128479e516a9b112c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Anders=20Granskogen=20Bj=C3=B8rnstad?= <anders@imerso.com>
Date: Mon, 4 Dec 2017 17:06:13 +0100
Subject: [PATCH] SvgSerializer: Fix bug in ellipse writeout

Add a missing "=" to create a valid SVG for ellipses.

I accidentally stumbled upon a way to actually get an ellipse in SVG by
tilting a cylinder. If I tilt the cylinder via the `ObjectPlacement` of
the `IfcProduct` I get an ellipse. If I set the `ExtrudedDirection` of
the `IfcExtrudedAreasolid`, however, I get a sampled path.
---
 src/ifcconvert/SvgSerializer.cpp | 2 +-
 test/input/cylinders.ifc         | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/ifcconvert/SvgSerializer.cpp b/src/ifcconvert/SvgSerializer.cpp
index 695923cd4b..d2eab2219f 100644
--- a/src/ifcconvert/SvgSerializer.cpp
+++ b/src/ifcconvert/SvgSerializer.cpp
@@ -107,7 +107,7 @@ void SvgSerializer::write(path_object& p, const TopoDS_Wire& wire) {
                     // Write the ellipse with major radius along X axis:
                     path.add("            <ellipse style=\"stroke:black; fill:none;\" rx=\"");
                     radii.push_back(path.add(e.MajorRadius()));
-                    path.add("\" ry\"");
+                    path.add("\" ry=\"");
                     radii.push_back(path.add(e.MinorRadius()));
                     path.add("\" cx=\"");
                     xcoords.push_back(path.add(center.X()));
diff --git a/test/input/cylinders.ifc b/test/input/cylinders.ifc
index f8547ed262..881fd21d02 100644
--- a/test/input/cylinders.ifc
+++ b/test/input/cylinders.ifc
@@ -28,7 +28,7 @@ DATA;
 #21=IFCCARTESIANPOINT((0.,0.));
 #22=IFCDIRECTION((1.,0.));
 #23=IFCAXIS2PLACEMENT2D(#21,#22);
-#24=IFCCIRCLEPROFILEDEF(.AREA.,'Circle',#23,0.5);
+#24=IFCCIRCLEPROFILEDEF(.AREA.,'Circle',#23,0.4);
 #25=IFCCARTESIANPOINT((0.,0.,0.));
 #26=IFCAXIS2PLACEMENT3D(#25,$,$);
 #27=IFCDIRECTION((0.,0.,1.));
@@ -36,11 +36,11 @@ DATA;
 #29=IFCSHAPEREPRESENTATION(#11,'Body','SweptSolid',(#28));
 #30=IFCPRODUCTDEFINITIONSHAPE($,$,(#29));
 #31=IFCCARTESIANPOINT((0.,0.,0.));
-#32=IFCDIRECTION((0.,0.,1.));
+#32=IFCDIRECTION((0.284030681745204,-0.260541987798268,0.922737473185891));
 #33=IFCDIRECTION((1.,0.,0.));
 #34=IFCAXIS2PLACEMENT3D(#31,#32,#33);
 #35=IFCLOCALPLACEMENT($,#34);
-#36=IFCBUILDINGELEMENTPROXY('0qs7mimyyHvuvRW1aqWGIT',#5,'Vertical cylinder',$,$,#35,#30,$,$);
+#36=IFCBUILDINGELEMENTPROXY('0qs7mimyyHvuvRW1aqWGIT',#5,'Tilted cylinder',$,$,#35,#30,$,$);
 #37=IFCCARTESIANPOINT((0.,0.));
 #38=IFCDIRECTION((1.,0.));
 #39=IFCAXIS2PLACEMENT2D(#37,#38);