From 39e331fb5a08ddfb6704e25f7fa0b3bb9d0e9908 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Wed, 9 Sep 2026 14:35:30 +0500 Subject: [PATCH] cmake: drop commented out static VC runtime linking Commented out long time ago in ec04644. Nowadays static linking would be done differently - using `CMAKE_MSVC_RUNTIME_LIBRARY`, but we don't really support static runtime. --- cmake/CMakeLists.txt | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index c3b1dd7387..197ec09849 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -479,21 +479,6 @@ if(MSVC) add_definitions(-permissive-) endif() - # Link against the static VC runtime - # TODO Make this configurable - # if("$ENV{CONDA_BUILD}" STREQUAL "") - # foreach(flag CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE CMAKE_CXX_FLAGS_MINSIZEREL - # CMAKE_CXX_FLAGS_RELWITHDEBINFO CMAKE_C_FLAGS CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_RELEASE - # CMAKE_C_FLAGS_MINSIZEREL CMAKE_C_FLAGS_RELWITHDEBINFO) - # if(${flag} MATCHES "/MD") - # STRING(REGEX REPLACE "/MD" "/MT" ${flag} "${${flag}}") - # endif() - # if(${flag} MATCHES "/MDd") - # STRING(REGEX REPLACE "/MDd" "/MTd" ${flag} "${${flag}}") - # endif() - # endforeach() - # endif() - add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) # See #5158. if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.40)