From 3d787338fbb235403c473ed7d51fd207757937a4 Mon Sep 17 00:00:00 2001 From: Totally a booplicate <53382877+Booplicate@users.noreply.github.com> Date: Sun, 4 Jun 2023 14:45:23 +0300 Subject: [PATCH] improve naming of the new method --- src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py index f67faff885..de76957327 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py +++ b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py @@ -174,9 +174,9 @@ class Usecase: self.psetqto = ifcopenshell.util.pset.get_template(self.file.schema) self.pset_template = self.psetqto.get_by_name(self.settings["pset"].Name) - def _has_property(self, prop) -> bool: + def _should_update_prop(self, prop) -> bool: """ - Checks if the property already exists + Checks if the given property should be changed """ return prop.Name in self.settings["properties"] @@ -199,7 +199,7 @@ class Usecase: # just delete the property first? - vulevukusej def update_existing_properties(self): for prop in self.get_properties(): - if not self._has_property(prop): + if not self._should_update_prop(prop): continue if prop.is_a("IfcPropertyEnumeratedValue"):