From 3d81660dad85a077bbb705d553e95c88152074bc Mon Sep 17 00:00:00 2001 From: Gorgious56 Date: Tue, 26 May 2026 16:59:44 +0200 Subject: [PATCH] Use util.unit.mm_to_m in add_window_representation Drops the module-local ``mm()`` helper in favour of the centralised ``ifcopenshell.util.unit.mm_to_m`` (added earlier in this PR). The ``as mm`` import alias preserves the existing call sites' readability. Generated with the assistance of an AI coding tool. --- .../ifcopenshell/api/geometry/add_window_representation.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py b/src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py index 36848e7883..7ca50c2348 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py +++ b/src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py @@ -27,6 +27,7 @@ import numpy as np import ifcopenshell.api.geometry import ifcopenshell.util.unit from ifcopenshell.util.shape_builder import ShapeBuilder, V +from ifcopenshell.util.unit import mm_to_m as mm # SCHEMAS describe panels setup # where: @@ -59,11 +60,6 @@ DEFAULT_PANEL_SCHEMAS = { } -def mm(x: float) -> float: - """mm to meters shortcut for readability""" - return x / 1000 - - def create_ifc_window_frame_simple( builder: ShapeBuilder, size: np.ndarray, thickness: Union[list[float], float], position: Optional[np.ndarray] = None ) -> list[ifcopenshell.entity_instance]: