From 402591e71c23821b3ea8012bf1601c37a2e1975f Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Fri, 10 Jul 2026 12:53:32 +1000 Subject: [PATCH] ci: restore --shared on the Rocky builds (undo datamodel-merge regression) The datamodel-v1.0 merge (cf05bbd1b) overwrote build_rocky.yml with a version that switched python3 -> uv run but dropped the --shared flag that a91b1da28 ("Reduce Rocky package size") had added. build_osx.yml kept it (ddee88bed). Without --shared, nix/build-all.py builds IfcOpenShell as static libs, so each of the ~40 plug-in .so files (schemas x8, kernels, mappings, serializers, writers) statically embeds a full copy of libIfcParse + libIfcGeom. The data-model rewrite made those base libs much larger, so the duplication ballooned the Linux packages (~2-3x). With --shared the plug-ins dynamically reference the shared libIfcParse/libIfcGeom instead. Restores the same size reduction macOS already has. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/build_rocky.yml | 2 +- .github/workflows/build_rocky_arm.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_rocky.yml b/.github/workflows/build_rocky.yml index 2841ad6e34..f36f68ebe4 100644 --- a/.github/workflows/build_rocky.yml +++ b/.github/workflows/build_rocky.yml @@ -81,7 +81,7 @@ jobs: shell: bash run: | set -o pipefail - CXXFLAGS="-O3" CFLAGS="-O3 ${DARWIN_C_SOURCE}" ADD_COMMIT_SHA=1 BUILD_CFG=Release BUILD_BONSAIVIEWER=ON uv run --with typing_extensions --with aqtinstall ./nix/build-all.py -v --diskcleanup 2>&1 | tee build.log + CXXFLAGS="-O3" CFLAGS="-O3 ${DARWIN_C_SOURCE}" ADD_COMMIT_SHA=1 BUILD_CFG=Release BUILD_BONSAIVIEWER=ON uv run --with typing_extensions --with aqtinstall ./nix/build-all.py -v --diskcleanup --shared 2>&1 | tee build.log - name: Upload Build Logs if: always() diff --git a/.github/workflows/build_rocky_arm.yml b/.github/workflows/build_rocky_arm.yml index 9d6b5b9754..2fe804505b 100644 --- a/.github/workflows/build_rocky_arm.yml +++ b/.github/workflows/build_rocky_arm.yml @@ -92,7 +92,7 @@ jobs: shell: bash run: | set -o pipefail - CXXFLAGS="-O3" CFLAGS="-O3 ${DARWIN_C_SOURCE}" ADD_COMMIT_SHA=1 BUILD_CFG=Release BUILD_BONSAIVIEWER=ON uv run --with typing_extensions --with aqtinstall ./nix/build-all.py -v --diskcleanup 2>&1 | tee build.log + CXXFLAGS="-O3" CFLAGS="-O3 ${DARWIN_C_SOURCE}" ADD_COMMIT_SHA=1 BUILD_CFG=Release BUILD_BONSAIVIEWER=ON uv run --with typing_extensions --with aqtinstall ./nix/build-all.py -v --diskcleanup --shared 2>&1 | tee build.log - name: Upload Build Logs if: always()