Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-28 03:05:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

See #1227. Slightly more defensive to make sure ATPATH is between START and END

Browse Source
This commit is contained in:
Dion Moult
2025-03-09 18:31:43 +11:00
parent 7503530741
commit 4109b19c3a
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/regenerate_wall_representation.py
+8 -2
View File
@@ -240,7 +240,13 @@ class Regenerator:
else: else:
# A wall footprint may be multiple profiles if the wall is split into two due to an ATPATH connection # A wall footprint may be multiple profiles if the wall is split into two due to an ATPATH connection
profiles = [] profiles = []
split_points = sorted(self.split_points, key=lambda x: x[0][0]) # Sort islands in the +X direction minx = max([p[0] for p in self.start_points])
maxx = min([p[0] for p in self.end_points])
split_points = []
for points in sorted(self.split_points, key=lambda x: x[0][0]): # Sort islands in the +X direction
if any([p[0] > maxx or p[0] < minx for p in points]): # Can't have anything outside our start/end
continue
split_points.append(points)
start_points = [p.copy() for p in self.start_points] start_points = [p.copy() for p in self.start_points]
end_points = [p.copy() for p in self.end_points] end_points = [p.copy() for p in self.end_points]
split_points.insert(0, start_points) split_points.insert(0, start_points)
@@ -259,7 +265,7 @@ class Regenerator:
maxy_maxx = end_split[-1][0] maxy_maxx = end_split[-1][0]
miny_minx = start_split[0][0] miny_minx = start_split[0][0]
miny_maxx = end_split[0][0] miny_maxx = end_split[0][0]
# Do more defensive checks here # Do more defensive checks here?
points = start_split points = start_split
remaining_path_points = [] remaining_path_points = []