From 41eadf735e451e1380170e380a1208874edf443a Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Wed, 7 May 2025 12:19:15 +0500 Subject: [PATCH] add_representation - more readable error on using panoramic camera --- .../ifcopenshell/api/geometry/add_representation.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ifcopenshell-python/ifcopenshell/api/geometry/add_representation.py b/src/ifcopenshell-python/ifcopenshell/api/geometry/add_representation.py index e39887f7b1..b95f0f7945 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/geometry/add_representation.py +++ b/src/ifcopenshell-python/ifcopenshell/api/geometry/add_representation.py @@ -300,11 +300,13 @@ class Usecase: return self.create_swept_disk_solid_representation() elif isinstance(self.settings["geometry"], bpy.types.Curve): return self.create_curve3d_representation() - elif isinstance(self.settings["geometry"], bpy.types.Camera): - if self.settings["geometry"].type == "ORTHO": + elif isinstance(self.geometry, bpy.types.Camera): + if self.geometry.type == "ORTHO": return self.create_camera_block_representation() - elif self.settings["geometry"].type == "PERSP": + elif self.geometry.type == "PERSP": return self.create_camera_pyramid_representation() + else: + raise ValueError(f"Unsupported camera type: '{self.geometry.type}'.") elif not len(self.settings["geometry"].edges): return self.create_point_cloud_representation() elif not len(self.settings["geometry"].polygons):