Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-17 22:11:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Less useless logging

Browse Source
This commit is contained in:
Thomas Krijnen
2026-04-10 09:54:28 +02:00
parent 1840e3d1a8
commit 4621fc9269
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/AbstractKernel.h
+8 -4
View File
@@ -149,8 +149,10 @@ namespace {
template <> template <>
struct dispatch_conversion<ifcopenshell::geometry::taxonomy::type_by_kind::max> { struct dispatch_conversion<ifcopenshell::geometry::taxonomy::type_by_kind::max> {
static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel*, ifcopenshell::geometry::taxonomy::kinds, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) { static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* k, ifcopenshell::geometry::taxonomy::kinds, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) {
logger::error("No conversion for " + std::to_string(item->kind())); if (k->partial_success_is_success) {
logger::error("No conversion for " + std::to_string(item->kind()));
}
return false; return false;
} }
}; };
@@ -169,8 +171,10 @@ namespace {
template <> template <>
struct dispatch_with_upgrade<ifcopenshell::geometry::taxonomy::upgrades::max> { struct dispatch_with_upgrade<ifcopenshell::geometry::taxonomy::upgrades::max> {
static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel*, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) { static bool dispatch(ifcopenshell::geometry::kernels::AbstractKernel* k, const ifcopenshell::geometry::taxonomy::ptr& item, IfcGeom::ConversionResults&) {
logger::error("No conversion with upgrade for " + std::to_string(item->kind())); if (k->partial_success_is_success) {
logger::error("No conversion with upgrade for " + std::to_string(item->kind()));
}
return false; return false;
} }
}; };
src/ifcgeom/mapping/mapping.cpp
+5
View File
@@ -554,6 +554,11 @@ IfcSchema::IfcStyledItem mapping::find_style(const IfcSchema::IfcRepresentationI
taxonomy::ptr mapping::map_impl(const IfcSchema::IfcMaterial& material) { taxonomy::ptr mapping::map_impl(const IfcSchema::IfcMaterial& material) {
std::vector<IfcSchema::IfcMaterialDefinitionRepresentation> defs = material.HasRepresentation(); std::vector<IfcSchema::IfcMaterialDefinitionRepresentation> defs = material.HasRepresentation();
if (defs.size() == 0) {
failed_on_purpose_.insert(material);
}
for (auto jt = defs.begin(); jt != defs.end(); ++jt) { for (auto jt = defs.begin(); jt != defs.end(); ++jt) {
std::vector<IfcSchema::IfcRepresentation> reps = (*jt).Representations(); std::vector<IfcSchema::IfcRepresentation> reps = (*jt).Representations();
std::vector<IfcSchema::IfcStyledItem> styles; std::vector<IfcSchema::IfcStyledItem> styles;