Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-24 01:07:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes IfcSectionedSurface and IfcSectionedSolidHorizontal use of PBE.OffsetLateral and OffsetVertical by adding unit conversion factor.

Browse Source
This commit is contained in:
Richard Brice
2026-08-18 08:57:13 -07:00
parent 1af5cc9bbe
commit 472482a87c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp
+2 -2
View File
@@ -62,9 +62,9 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in
longitudes.push_back(*pbde->DistanceAlong()->as<IfcSchema::IfcLengthMeasure>(true) * length_unit_); longitudes.push_back(*pbde->DistanceAlong()->as<IfcSchema::IfcLengthMeasure>(true) * length_unit_);
Eigen::Vector3d po( Eigen::Vector3d po(
pbde->OffsetLateral().get_value_or(0.), pbde->OffsetLateral().get_value_or(0.) * length_unit_,
// @todo I don't understand whether vertical is an offset relative to the tangent plane or to the global XY plane // @todo I don't understand whether vertical is an offset relative to the tangent plane or to the global XY plane
pbde->OffsetVertical().get_value_or(0.), pbde->OffsetVertical().get_value_or(0.) * length_unit_,
0.); 0.);
profile_offsets.push_back(po); profile_offsets.push_back(po);
src/ifcgeom/mapping/IfcSectionedSurface.cpp
+2 -2
View File
@@ -64,9 +64,9 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSurface* inst) {
longitudes.push_back(*pbde->DistanceAlong()->as<IfcSchema::IfcLengthMeasure>(true) * length_unit_); longitudes.push_back(*pbde->DistanceAlong()->as<IfcSchema::IfcLengthMeasure>(true) * length_unit_);
Eigen::Vector3d po( Eigen::Vector3d po(
pbde->OffsetLateral().get_value_or(0.), pbde->OffsetLateral().get_value_or(0.) * length_unit_,
// @todo I don't understand whether vertical is an offset relative to the tangent plane or to the global XY plane // @todo I don't understand whether vertical is an offset relative to the tangent plane or to the global XY plane
pbde->OffsetVertical().get_value_or(0.), pbde->OffsetVertical().get_value_or(0.) * length_unit_,
0.); 0.);
profile_offsets.push_back(po); profile_offsets.push_back(po);