Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-11 14:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use util.unit.mm_to_m in add_window_representation

Browse Source 
Drops the module-local ``mm()`` helper in favour of the centralised
``ifcopenshell.util.unit.mm_to_m`` (added earlier in this PR). The
``as mm`` import alias preserves the existing call sites' readability.

Generated with the assistance of an AI coding tool.
This commit is contained in:
Gorgious56
2026-05-26 16:59:44 +02:00
committed by Thomas Krijnen
parent 38fab26000
commit 4bbcb59259
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py
+1 -5
View File
@@ -27,6 +27,7 @@ import numpy as np
import ifcopenshell.api.geometry import ifcopenshell.api.geometry
import ifcopenshell.util.unit import ifcopenshell.util.unit
from ifcopenshell.util.shape_builder import ShapeBuilder, V from ifcopenshell.util.shape_builder import ShapeBuilder, V
from ifcopenshell.util.unit import mm_to_m as mm
# SCHEMAS describe panels setup # SCHEMAS describe panels setup
# where: # where:
@@ -59,11 +60,6 @@ DEFAULT_PANEL_SCHEMAS = {
} }
def mm(x: float) -> float:
"""mm to meters shortcut for readability"""
return x / 1000
def create_ifc_window_frame_simple( def create_ifc_window_frame_simple(
builder: ShapeBuilder, size: np.ndarray, thickness: Union[list[float], float], position: Optional[np.ndarray] = None builder: ShapeBuilder, size: np.ndarray, thickness: Union[list[float], float], position: Optional[np.ndarray] = None
) -> list[ifcopenshell.entity_instance]: ) -> list[ifcopenshell.entity_instance]: