From 526a2a6a800caeeb90dafc1cc003e976745da58b Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Fri, 9 Aug 2024 15:58:46 +0500 Subject: [PATCH] bcf - return added viewpoint in add_visinfo_handler #4453 --- src/bcf/bcf/v2/topic.py | 9 +++++++-- src/bcf/bcf/v3/topic.py | 9 ++++++--- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/bcf/bcf/v2/topic.py b/src/bcf/bcf/v2/topic.py index 9617cb41bf..88c991ae0b 100644 --- a/src/bcf/bcf/v2/topic.py +++ b/src/bcf/bcf/v2/topic.py @@ -293,9 +293,14 @@ class TopicHandler: self.add_visinfo_handler(vi_handler) return vi_handler - def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: + def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> mdl.ViewPoint: self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint - self.markup.viewpoints.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid)) + viewpoint = mdl.ViewPoint( + viewpoint=new_viewpoint.guid + ".bcfv", + guid=new_viewpoint.guid, + ) + self.markup.viewpoints.append(viewpoint) + return viewpoint def __eq__(self, other: object) -> bool | NoReturn: return ( diff --git a/src/bcf/bcf/v3/topic.py b/src/bcf/bcf/v3/topic.py index 47a37330b5..dbdc1e0fc3 100644 --- a/src/bcf/bcf/v3/topic.py +++ b/src/bcf/bcf/v3/topic.py @@ -191,13 +191,16 @@ class TopicHandler: self.add_visinfo_handler(vi_handler) return vi_handler - def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: + def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> mdl.ViewPoint: self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint if self.topic.viewpoints is None: self.topic.viewpoints = mdl.TopicViewpoints() - self.topic.viewpoints.view_point.append( - mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid) + viewpoint = mdl.ViewPoint( + viewpoint=new_viewpoint.guid + ".bcfv", + guid=new_viewpoint.guid, ) + self.topic.viewpoints.view_point.append(viewpoint) + return viewpoint def __eq__(self, other: object) -> bool | NoReturn: return (