Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-17 22:11:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes double unit conversion when convert-back-units are used

Browse Source
This commit is contained in:
Richard Brice
2026-07-10 07:55:51 -07:00
committed by Thomas Krijnen
parent 206cd6bbe1
commit 52d894298e
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcwrap/IfcGeomWrapper.i
+2
View File
@@ -977,12 +977,14 @@ struct ShapeRTTI : public boost::static_visitor<PyObject*>
if (item == nullptr) { if (item == nullptr) {
throw IfcParse::IfcException("Failed to convert placement"); throw IfcParse::IfcException("Failed to convert placement");
} }
/*
if (st.get<ifcopenshell::geometry::settings::ConvertBackUnits>().get()) { if (st.get<ifcopenshell::geometry::settings::ConvertBackUnits>().get()) {
// we pass the settings to the Transformation object, but access the data just offloads to the // we pass the settings to the Transformation object, but access the data just offloads to the
// generic cartesian_base<Matrix4> so there's no time to apply the settings to the translation part. // generic cartesian_base<Matrix4> so there's no time to apply the settings to the translation part.
item = ifcopenshell::geometry::taxonomy::matrix4::ptr(item->clone_()); item = ifcopenshell::geometry::taxonomy::matrix4::ptr(item->clone_());
item->components().col(3).head<3>() /= kernel.settings().get<ifcopenshell::geometry::settings::LengthUnit>().get(); item->components().col(3).head<3>() /= kernel.settings().get<ifcopenshell::geometry::settings::LengthUnit>().get();
} }
*/
return new IfcGeom::Transformation(kernel.settings(), item); return new IfcGeom::Transformation(kernel.settings(), item);
} else { } else {
if (!representation) { if (!representation) {