Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-11 14:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

IfcSectionedSolidHorizontal logs warning if Directrix is not a piecewise function, rather than silently failing.

Browse Source
This commit is contained in:
Richard Brice
2024-07-22 13:21:49 -07:00
parent 93fe2e9b0f
commit 54131b3fe5
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp
+3 -1
View File
@@ -52,7 +52,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in
auto pwf = taxonomy::dcast<taxonomy::piecewise_function>(dir); auto pwf = taxonomy::dcast<taxonomy::piecewise_function>(dir);
if (!pwf) { if (!pwf) {
// Only implement on alignment curves // Only implement on alignment curves
return nullptr; Logger::Warning("IfcSectionedSolidHorizontal is only implemented for piecewise function Directrix curves", inst);
return nullptr;
} }
{ {
@@ -111,6 +112,7 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in
loft->axis = nullptr; loft->axis = nullptr;
// @todo currently only the case is handled where directrix returns a piecewise_function // @todo currently only the case is handled where directrix returns a piecewise_function
// @todo this "if" statement is not really required because the function returns at the start if the Directrix is not a piecewise function
if (pwf) { if (pwf) {
double start = std::max(0., cross_sections.front().dist_along); double start = std::max(0., cross_sections.front().dist_along);
double end = std::min(pwf->length(), cross_sections.back().dist_along); double end = std::min(pwf->length(), cross_sections.back().dist_along);