From 567bc7b667ce0397e673a0bc98a058e7947b51d7 Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Fri, 18 Jun 2021 08:03:44 +1000 Subject: [PATCH] Fix confusing transparency attribute in add style API usecase. See #1529. --- src/blenderbim/blenderbim/bim/module/style/operator.py | 1 + src/ifcopenshell-python/ifcopenshell/api/style/add_style.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/blenderbim/blenderbim/bim/module/style/operator.py b/src/blenderbim/blenderbim/bim/module/style/operator.py index 9deac2e45d..0ca1c8af3a 100644 --- a/src/blenderbim/blenderbim/bim/module/style/operator.py +++ b/src/blenderbim/blenderbim/bim/module/style/operator.py @@ -10,6 +10,7 @@ def get_colour_settings(material): bsdf = material.node_tree.nodes["Principled BSDF"] transparency = bsdf.inputs["Alpha"].default_value diffuse_colour = bsdf.inputs["Base Color"].default_value + transparency = 1 - transparency return { "surface_colour": tuple(material.diffuse_color), "transparency": transparency, diff --git a/src/ifcopenshell-python/ifcopenshell/api/style/add_style.py b/src/ifcopenshell-python/ifcopenshell/api/style/add_style.py index bc7c894e3a..7594462cbc 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/style/add_style.py +++ b/src/ifcopenshell-python/ifcopenshell/api/style/add_style.py @@ -23,7 +23,7 @@ class Usecase: "IfcSurfaceStyleRendering", **{ "SurfaceColour": self.create_colour_rgb(self.settings["surface_colour"]), - "Transparency": (self.settings["transparency"] - 1) * -1, + "Transparency": self.settings["transparency"], "ReflectanceMethod": "NOTDEFINED", "DiffuseColour": self.create_colour_rgb(self.settings["diffuse_colour"]), }