Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-16 21:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

IfcConvert: remove unmaintained WITH_RELATIONSHIP_VALIDATION feature

Browse Source 
The validate_space_boundaries, validate_storey_containment and
validate_wall_connectivity translation units only ever built when the
default-off WITH_RELATIONSHIP_VALIDATION CMake option was enabled, and
their fix_* entry points were never reachable from the IfcConvert
command line. The code has drifted from the current geometry kernel API
(Iterator now takes a std::unique_ptr<AbstractKernel>,
create_nef_polyhedron takes a CGAL polyhedron rather than a CgalShape),
so any build with the option enabled fails to compile, as reported in
the issue for MSVC and reproducible with clang on macOS.

Per maintainer direction on the issue, remove the feature instead of
patching it: the plan is to redo this kind of validation in Python on
top of ConversionResult(Shape). This deletes the validation sources,
the option, and the conditional source glob, leaving IfcConvert built
from IfcConvert.cpp alone, which was already the default.

Fixes #7444.

Generated with the assistance of an AI coding tool.
This commit is contained in:
Petru Conduraru
2026-07-19 23:41:24 +03:00
parent 89523999b3
commit 57c3d4b176
7 changed files with 1 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmake/CMakeLists.txt
-1
View File
@@ -104,7 +104,6 @@ option(HDF5_SUPPORT "Enable HDF5 support (requires HDF5, zlib)" ON)
option(WITH_PROJ "Enable output of Earth-Centered Earth-Fixed glTF output using the PROJ library" OFF)
option(IFCXML_SUPPORT "Build IfcParse with ifcXML support (requires libxml2)." ON)
option(USD_SUPPORT "Build IfcConvert with USD support (requires pixar's USD library)." OFF)
option(WITH_RELATIONSHIP_VALIDATION "Build IfcConvert with option to validate geometrical relationships." OFF)
option(WITH_ROCKSDB "Support a RocksDB key-value store as a file backend in IfcOpenShell" OFF)
option(WITH_ZSTD "Use Zstd compression in RocksDB writes" OFF)