Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 14:41:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify Compound of Solids behaviour in create_solid_from_faces() #6780

Browse Source
This commit is contained in:
Thomas Krijnen
2025-06-05 10:22:28 +02:00
parent 1ce9a4c68e
commit 5af7c9a32d
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/kernels/opencascade/base_utils.h
+2
View File
@@ -45,6 +45,8 @@ namespace IfcGeom {
bool is_nested_compound_of_solid(const TopoDS_Shape& s, int depth = 0); bool is_nested_compound_of_solid(const TopoDS_Shape& s, int depth = 0);
// Creates a solid from a compound of faces. When there are multiple connected components,
// a compound of solids is returned.
bool create_solid_from_compound(const TopoDS_Shape& compound, TopoDS_Shape& solid, double tol); bool create_solid_from_compound(const TopoDS_Shape& compound, TopoDS_Shape& solid, double tol);
bool shape_to_face_list(const TopoDS_Shape& s, TopTools_ListOfShape& li); bool shape_to_face_list(const TopoDS_Shape& s, TopTools_ListOfShape& li);
bool create_solid_from_faces(const TopTools_ListOfShape& face_list, TopoDS_Shape& solid, double tol, bool force_sewing = false); bool create_solid_from_faces(const TopTools_ListOfShape& face_list, TopoDS_Shape& solid, double tol, bool force_sewing = false);
src/ifcgeom/kernels/opencascade/boolean_utils.cpp
+3 -3
View File
@@ -1451,10 +1451,10 @@ TopoDS_Shape IfcGeom::util::ensure_fit_for_subtraction(const TopoDS_Shape& shape
return shape; return shape;
} }
TopoDS_Solid solid; TopoDS_Shape solid_or_compound_of_solids;
if (!create_solid_from_compound(shape, solid, tol)) { if (!create_solid_from_compound(shape, solid_or_compound_of_solids, tol)) {
return shape; return shape;
} }
return solid; return solid_or_compound_of_solids;
} }