bim.assign_system/unassign_system - add info messages

Also check whether element is assignable prior to running system.assign_system to avoid scary exceptions.

src/bonsai/bonsai/bim/module/system/operator.py

@@ -18,6 +18,7 @@
 
 import bpy
 import ifcopenshell.api
+import ifcopenshell.util.system
 import bonsai.tool as tool
 import bonsai.core.system as core
 import bonsai.bim.helper
@@ -98,27 +99,60 @@ class DisableEditingSystem(bpy.types.Operator):
 class AssignSystem(bpy.types.Operator, tool.Ifc.Operator):
     bl_idname = "bim.assign_system"
     bl_label = "Assign System"
+    bl_description = "Assign system to the selected objects.\n\nIf object is not assignable to this type of system, it will be skiped."
     bl_options = {"REGISTER", "UNDO"}
     system: bpy.props.IntProperty()
 
+    @classmethod
+    def poll(cls, context):
+        if not context.selected_objects:
+            cls.poll_message_set("No objects selected.")
+            return False
+        return True
+
     def _execute(self, context):
-        for obj in context.selected_objects:
+        elements = [e for o in context.selected_objects if (e := tool.Ifc.get_entity(o))]
-            element = tool.Ifc.get_entity(obj)
+        if not elements:
-            if element:
+            self.report({"ERROR"}, "No IFC elements selected.")
-                core.assign_system(tool.Ifc, system=tool.Ifc.get().by_id(self.system), product=element)
+            return {"CANCELLED"}
+        system = tool.Ifc.get().by_id(self.system)
+        assignable_elements = [e for e in elements if ifcopenshell.util.system.is_assignable(e, system)]
+        if not assignable_elements:
+            supported_elements_str = ", ".join(ifcopenshell.util.system.group_types[system.is_a()])
+            self.report(
+                {"ERROR"},
+                f"No elements assignable to {system.is_a()} is selected.\n"
+                f"Assignable elements types are: {supported_elements_str}.",
+            )
+            return {"CANCELLED"}
+        core.assign_system(tool.Ifc, system=system, products=assignable_elements)
+        self.report({"INFO"}, f"System assigned to {len(assignable_elements)} elements.")
+        return {"FINISHED"}
 
 
 class UnassignSystem(bpy.types.Operator, tool.Ifc.Operator):
     bl_idname = "bim.unassign_system"
     bl_label = "Unassign System"
+    bl_description = "Unassign system from the selected objects."
     bl_options = {"REGISTER", "UNDO"}
     system: bpy.props.IntProperty()
 
+    @classmethod
+    def poll(cls, context):
+        if not context.selected_objects:
+            cls.poll_message_set("No objects selected.")
+            return False
+        return True
+
     def _execute(self, context):
-        for obj in context.selected_objects:
+        elements = [e for o in context.selected_objects if (e := tool.Ifc.get_entity(o))]
-            element = tool.Ifc.get_entity(obj)
+        if not elements:
-            if element:
+            self.report({"ERROR"}, "No IFC elements selected.")
-                core.unassign_system(tool.Ifc, system=tool.Ifc.get().by_id(self.system), product=element)
+            return {"CANCELLED"}
+        system = tool.Ifc.get().by_id(self.system)
+        core.unassign_system(tool.Ifc, system=system, products=elements)
+        self.report({"INFO"}, f"System unassigned from {len(elements)} elements.")
+        return {"FINISHED"}
 
 
 class SelectSystemProducts(bpy.types.Operator):

src/bonsai/bonsai/core/system.py

@@ -62,12 +62,16 @@ def disable_editing_system(system: tool.System) -> None:
     system.disable_editing_system()
 
 
-def assign_system(ifc: tool.Ifc, system: ifcopenshell.entity_instance, product: ifcopenshell.entity_instance) -> None:
+def assign_system(
-    ifc.run("system.assign_system", products=[product], system=system)
+    ifc: tool.Ifc, system: ifcopenshell.entity_instance, products: list[ifcopenshell.entity_instance]
+) -> None:
+    ifc.run("system.assign_system", products=products, system=system)
 
 
-def unassign_system(ifc: tool.Ifc, system: ifcopenshell.entity_instance, product: ifcopenshell.entity_instance) -> None:
+def unassign_system(
-    ifc.run("system.unassign_system", products=[product], system=system)
+    ifc: tool.Ifc, system: ifcopenshell.entity_instance, products: list[ifcopenshell.entity_instance]
+) -> None:
+    ifc.run("system.unassign_system", products=products, system=system)
 
 
 def select_system_products(system_tool: tool.System, system: ifcopenshell.entity_instance) -> None: