From 5bb769448d1f07a443abc189a538751da53e85de Mon Sep 17 00:00:00 2001
From: Andrej730 <azhilenkov@gmail.com>
Date: Wed, 21 May 2025 17:41:02 +0500
Subject: [PATCH] bim.execute_ifc_clash - show results in Bonsai UI for bcf
 file too

Previously results would show up only if you'd save .json, creating confusion since UI is showing "0 Clashes Found" though there were clashes.
---
 .../bonsai/bim/module/clash/operator.py       | 19 ++++++++++++++++---
 src/bonsai/bonsai/tool/clash.py               |  3 +++
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/src/bonsai/bonsai/bim/module/clash/operator.py b/src/bonsai/bonsai/bim/module/clash/operator.py
index 604ae559bb..be682a83c6 100644
--- a/src/bonsai/bonsai/bim/module/clash/operator.py
+++ b/src/bonsai/bonsai/bim/module/clash/operator.py
@@ -19,6 +19,7 @@
 import os
 import bpy
 import json
+import tempfile
 import bmesh
 import logging
 import numpy as np
@@ -237,12 +238,13 @@ class ExecuteIfcClash(bpy.types.Operator, ExportHelper):
                         )
                         return {"CANCELLED"}
 
-        _, extension = os.path.splitext(self.filepath)
+        extension = Path(self.filepath).suffix.lower()
         if extension != ".bcf":
             self.filepath = bpy.path.ensure_ext(self.filepath, ".json")
         # TODO Temporarily until BCF support comes back
         if extension != ".json":
             self.filepath = bpy.path.ensure_ext(self.filepath, ".bcf")
+        assert extension in (".bcf", ".json")
 
         self.props.export_path = self.filepath
         settings = ifcclash.ClashSettings()
@@ -300,9 +302,20 @@ class ExecuteIfcClash(bpy.types.Operator, ExportHelper):
         clasher.clash()
         clasher.export()
 
-        if extension == ".json":
+        # Load clash results to UI.
+        if extension == ".bcf":
+            with tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False) as tmp:
+                try:
+                    tmp.close()
+                    settings.output = tmp.name
+                    clasher.export()
+                    tool.Clash.load_clash_sets(tmp.name)
+                finally:
+                    Path(tmp.name).unlink()
+        else:
             tool.Clash.load_clash_sets(self.filepath)
-            tool.Clash.import_active_clashes()
+        tool.Clash.import_active_clashes()
+
         self.report({"INFO"}, f"IFC Clash results are saved to '{Path(self.filepath).name}'.")
         return {"FINISHED"}
 
diff --git a/src/bonsai/bonsai/tool/clash.py b/src/bonsai/bonsai/tool/clash.py
index a5ac49c3e4..c4d2febf6d 100644
--- a/src/bonsai/bonsai/tool/clash.py
+++ b/src/bonsai/bonsai/tool/clash.py
@@ -112,6 +112,9 @@ class Clash(bonsai.core.tool.Clash):
 
     @classmethod
     def load_clash_sets(cls, fn: str) -> None:
+        """
+        :param fn: .json filepath to load clash results from.
+        """
         with open(fn) as f:
             ClashStore.clash_sets = json.load(f)