Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 22:50:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

append_asset - fix bug identifying None profiles as equivalent

Browse Source
This commit is contained in:
Andrej730
2025-01-23 12:55:59 +05:00
parent ad99990f17
commit 5bc91ec4e4
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/project/append_asset.py
+9 -6
View File
@@ -187,6 +187,8 @@ class Usecase:
return next((e for e in self.file.by_type("IfcMaterial") if e.Name == material_name), None) return next((e for e in self.file.by_type("IfcMaterial") if e.Name == material_name), None)
elif element.is_a("IfcProfileDef"): elif element.is_a("IfcProfileDef"):
profile_name = element.ProfileName profile_name = element.ProfileName
if profile_name is None:
return None
return next((e for e in self.file.by_type("IfcProfileDef") if e.ProfileName == profile_name), None) return next((e for e in self.file.by_type("IfcProfileDef") if e.ProfileName == profile_name), None)
else: else:
return None return None
@@ -443,12 +445,13 @@ class Usecase:
# Maybe element already exists. # Maybe element already exists.
if element.is_a("IfcProfileDef"): if element.is_a("IfcProfileDef"):
profile_name = element.ProfileName profile_name = element.ProfileName
existing_profile = next( if profile_name is not None:
(e for e in ifc_file.by_type("IfcProfileDef") if e.ProfileName == profile_name), None existing_profile = next(
) (e for e in ifc_file.by_type("IfcProfileDef") if e.ProfileName == profile_name), None
if existing_profile is not None: )
reuse_identities[element_identity] = existing_profile if existing_profile is not None:
return existing_profile reuse_identities[element_identity] = existing_profile
return existing_profile
elif element.is_a("IfcMaterial"): elif element.is_a("IfcMaterial"):
material_name = element.Name material_name = element.Name
existing_material = next((e for e in ifc_file.by_type("IfcMaterial") if e.Name == material_name), None) existing_material = next((e for e in ifc_file.by_type("IfcMaterial") if e.Name == material_name), None)