Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-10-02 04:59:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle RuntimeError in alignment geometry generation

Browse Source 
Add RuntimeError handling for IfcOpenShell versions that don't support
the piecewise-step-type setting in geometry generation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
DesertSpringsCivil
2026-02-01 18:40:49 -07:00
parent de2a7c9527
commit 6294c35a11
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/bonsai/tool/alignment.py
+2 -1
View File
@@ -308,7 +308,8 @@ class Alignment:
# Generate vertices using IfcOpenShell's geometry engine # Generate vertices using IfcOpenShell's geometry engine
try: try:
vertices = align_util.generate_vertices(rep_curve, distance_interval=1.0) vertices = align_util.generate_vertices(rep_curve, distance_interval=1.0)
except (ValueError, NotImplementedError): except (ValueError, NotImplementedError, RuntimeError):
# RuntimeError can occur if IfcOpenShell version doesn't support certain settings
return None return None
if len(vertices) < 2: if len(vertices) < 2:
src/ifcopenshell-python/ifcopenshell/api/alignment/util.py
+4 -1
View File
@@ -90,7 +90,10 @@ def generate_vertices(rep_curve: entity_instance, distance_interval: float = 5.0
) )
s = ifcopenshell.geom.settings() s = ifcopenshell.geom.settings()
s.set("piecewise-step-type", 0) # 0 = step-size is maximum step size, 1 = step-size is mininimum number of steps try:
s.set("piecewise-step-type", 0) # 0 = step-size is maximum step size, 1 = step-size is mininimum number of steps
except RuntimeError:
pass # Setting not available in older IfcOpenShell versions
s.set("piecewise-step-size", distance_interval) s.set("piecewise-step-size", distance_interval)
shape = ifcopenshell.geom.create_shape(s, rep_curve) shape = ifcopenshell.geom.create_shape(s, rep_curve)
vertices = shape.verts vertices = shape.verts