From 62ca6f6a7d2e79a03f9033b79b8d04fbc0425caf Mon Sep 17 00:00:00 2001 From: Ken Arroyo Ohori Date: Mon, 20 Mar 2017 16:45:27 -0600 Subject: [PATCH] Checked shapes with styles. Found bug? --- src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp b/src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp index 4898625956..2bfd8caaac 100644 --- a/src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp +++ b/src/ifcgeom/kernels/cgal/CgalIfcGeomShapesWithStyles.cpp @@ -79,8 +79,9 @@ bool IfcGeom::CgalKernel::convert(const IfcSchema::IfcManifoldSolidBrep* l, Conv for (IfcSchema::IfcClosedShell::list::it it = voids->begin(); it != voids->end(); ++it) { cgal_shape_t s2; - /// @todo No extensive shapefixing since shells should be disjoint. - /// @todo Awaiting generalized boolean ops module with appropriate checking + // TODO: This looks weird. Aren't we removing the outer shell again and again? + // Maybe it should be + // if (convert_shape(*it, s2)) { if (convert_shape(l->Outer(), s2)) { s -= s2; }