Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 17:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #2046. Fix crash if style was updated from an already loaded IFC dataset

Browse Source
This commit is contained in:
Dion Moult
2022-02-18 18:44:25 +11:00
parent 472a66b7ed
commit 63d65f0c39
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/test/api/style/test_remove_surface_style.py
+17 -1
View File
@@ -23,7 +23,7 @@ import ifcopenshell.api
class TestRemoveSurfaceStyle(test.bootstrap.IFC4):
def test_removing_a_shading_style(self):
style = self.file.createIfcSurfaceStyleShading(SurfaceColour=self.file.createIfcColourRgb())
style = self.file.createIfcSurfaceStyleShading(SurfaceColour=self.file.createIfcColourRgb(None, 1, 1, 1))
ifcopenshell.api.run("style.remove_surface_style", self.file, style=style)
assert len(list(self.file)) == 0
@@ -39,3 +39,19 @@ class TestRemoveSurfaceStyle(test.bootstrap.IFC4):
style = self.file.createIfcSurfaceStyleWithTextures(Textures=[texture])
ifcopenshell.api.run("style.remove_surface_style", self.file, style=style)
assert len(list(self.file)) == 0
def test_removing_a_rendering_style(self):
style = self.file.createIfcSurfaceStyleRendering(
SurfaceColour=self.file.createIfcColourRgb(None, 1, 1, 1),
Transparency=0.0,
DiffuseColour=self.file.createIfcColourRgb(None, 1, 1, 1),
TransmissionColour=self.file.createIfcNormalisedRatioMeasure(0.5),
SpecularHighlight=self.file.createIfcSpecularRoughness(0.5),
ReflectanceMethod="NOTDEFINED",
)
# See issue #2046, IfcOpenShell exhibits different behaviour - we can
# remove entity_instances() without an ID if we create them afresh, but
# will segfault if we load them stale.
g = ifcopenshell.file.from_string(self.file.wrapped_data.to_string())
ifcopenshell.api.run("style.remove_surface_style", g, style=g.by_type("IfcSurfaceStyleRendering")[0])
assert len(list(g)) == 0