Fix bug where copying objects did not necessarily retain the existing context assignment

2026-08-18 19:30:25 +00:00 · 2021-10-19 19:14:05 +11:00
parent 816059eefd
commit 6478601f79
11 changed files with 316 additions and 63 deletions
@@ -42,6 +42,20 @@ def aggregate():
    prophet.verify()


+@pytest.fixture
+def collector():
+    prophet = Prophecy(blenderbim.core.tool.Collector)
+    yield prophet
+    prophet.verify()
+
+
+@pytest.fixture
+def container():
+    prophet = Prophecy(blenderbim.core.tool.Container)
+    yield prophet
+    prophet.verify()
+
+
@pytest.fixture
 def context():
    prophet = Prophecy(blenderbim.core.tool.Context)
@@ -78,15 +92,8 @@ def owner():


@pytest.fixture
-def type():
-    prophet = Prophecy(blenderbim.core.tool.Type)
-    yield prophet
-    prophet.verify()
-
-
-@pytest.fixture
-def voider():
-    prophet = Prophecy(blenderbim.core.tool.Voider)
+def root():
+    prophet = Prophecy(blenderbim.core.tool.Root)
    yield prophet
    prophet.verify()

@@ -113,15 +120,15 @@ def surveyor():


@pytest.fixture
-def collector():
-    prophet = Prophecy(blenderbim.core.tool.Collector)
+def type():
+    prophet = Prophecy(blenderbim.core.tool.Type)
    yield prophet
    prophet.verify()


@pytest.fixture
-def container():
-    prophet = Prophecy(blenderbim.core.tool.Container)
+def voider():
+    prophet = Prophecy(blenderbim.core.tool.Voider)
    yield prophet
    prophet.verify()

@@ -0,0 +1,72 @@
+# BlenderBIM Add-on - OpenBIM Blender Add-on
+# Copyright (C) 2021 Dion Moult <dion@thinkmoult.com>
+#
+# This file is part of BlenderBIM Add-on.
+#
+# BlenderBIM Add-on is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# BlenderBIM Add-on is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with BlenderBIM Add-on.  If not, see <http://www.gnu.org/licenses/>.
+
+import blenderbim.core.root as subject
+import test.core.test_geometry
+from test.core.bootstrap import ifc, collector, root
+
+
+class TestCopyClass:
+    def test_doing_nothing_if_not_an_ifc_element(self, ifc, collector, root):
+        ifc.get_entity("obj").should_be_called().will_return(None)
+        subject.copy_class(ifc, collector, root, obj="obj")
+
+    def test_copy_with_new_geometry_derived_from_the_type(self, ifc, collector, root):
+        ifc.get_entity("obj").should_be_called().will_return("original_element")
+        ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
+        ifc.link("element", "obj").should_be_called()
+        root.get_element_type("element").should_be_called().will_return("type")
+        root.does_type_have_representations("type").should_be_called().will_return(True)
+        ifc.run("type.assign_type", related_object="element", relating_type="type").should_be_called()
+        collector.assign("obj").should_be_called()
+        root.is_opening_element("element").should_be_called().will_return(False)
+        subject.copy_class(ifc, collector, root, obj="obj")
+
+    def test_copy_with_new_geometry_added_afresh_for_speed(
+        self,
+        ifc,
+        collector,
+        root,
+    ):
+        ifc.get_entity("obj").should_be_called().will_return("original_element")
+        ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
+        ifc.link("element", "obj").should_be_called()
+        root.get_element_type("element").should_be_called().will_return("type")
+        root.does_type_have_representations("type").should_be_called().will_return(False)
+        root.get_object_context("obj").should_be_called().will_return("context")
+        root.run_geometry_add_representation(obj="obj", context="context").should_be_called()
+        collector.assign("obj").should_be_called()
+        root.is_opening_element("element").should_be_called().will_return(False)
+        subject.copy_class(ifc, collector, root, obj="obj")
+
+    def test_copied_openings_have_dynamic_voids_added(
+        self,
+        ifc,
+        collector,
+        root,
+    ):
+        ifc.get_entity("obj").should_be_called().will_return("original_element")
+        ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
+        ifc.link("element", "obj").should_be_called()
+        root.get_element_type("element").should_be_called().will_return("type")
+        root.does_type_have_representations("type").should_be_called().will_return(True)
+        ifc.run("type.assign_type", related_object="element", relating_type="type").should_be_called()
+        collector.assign("obj").should_be_called()
+        root.is_opening_element("element").should_be_called().will_return(True)
+        root.add_dynamic_opening_voids("element", "obj").should_be_called()
+        subject.copy_class(ifc, collector, root, obj="obj")
@@ -0,0 +1,97 @@
+# BlenderBIM Add-on - OpenBIM Blender Add-on
+# Copyright (C) 2021 Dion Moult <dion@thinkmoult.com>
+#
+# This file is part of BlenderBIM Add-on.
+#
+# BlenderBIM Add-on is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# BlenderBIM Add-on is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with BlenderBIM Add-on.  If not, see <http://www.gnu.org/licenses/>.
+
+import bpy
+import ifcopenshell
+import blenderbim.core.tool
+import blenderbim.tool as tool
+from test.bim.bootstrap import NewFile
+from blenderbim.tool.root import Root as subject
+
+
+class TestImplementsTool(NewFile):
+    def test_run(self):
+        assert isinstance(subject(), blenderbim.core.tool.Root)
+
+
+class TestAddDynamicOpeningVoids(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        tool.Ifc.set(ifc)
+
+        obj = bpy.data.objects.new("Object", bpy.data.meshes.new("Mesh"))
+        element = ifc.createIfcOpeningElement()
+        tool.Ifc.link(element, obj)
+
+        wall_obj = bpy.data.objects.new("Object", bpy.data.meshes.new("Mesh"))
+        wall_element = ifc.createIfcOpeningElement()
+        tool.Ifc.link(wall_element, wall_obj)
+
+        ifcopenshell.api.run("void.add_opening", ifc, opening=element, element=wall_element)
+
+        subject.add_dynamic_opening_voids(element, obj)
+
+        modifier = wall_obj.modifiers[0]
+        assert modifier.type == "BOOLEAN"
+        assert modifier.name == "IfcOpeningElement"
+        assert modifier.operation == "DIFFERENCE"
+        assert modifier.object == obj
+        assert modifier.solver == "EXACT"
+        assert modifier.use_self is True
+
+
+class TestDoesTypeHaveRepresentations(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        element = ifc.createIfcWallType()
+        assert subject.does_type_have_representations(element) is False
+        element.RepresentationMaps = [ifc.createIfcRepresentationMap()]
+        assert subject.does_type_have_representations(element) is True
+
+
+class TestGetElementType(NewFile):
+    def test_run(self):
+        bpy.ops.bim.create_project()
+        ifc = tool.Ifc.get()
+        element = ifc.createIfcWall()
+        type = ifc.createIfcWallType()
+        ifcopenshell.api.run("type.assign_type", ifc, related_object=element, relating_type=type)
+        assert subject.get_element_type(element) == type
+
+
+class TestGetElementType(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        tool.Ifc.set(ifc)
+        context = ifc.createIfcGeometricRepresentationContext()
+        representation = ifc.createIfcShapeRepresentation(ContextOfItems=context)
+        obj = bpy.data.objects.new("Object", bpy.data.meshes.new("Mesh"))
+        obj.data.BIMMeshProperties.ifc_definition_id = representation.id()
+        assert subject.get_object_context(obj) == context
+
+
+class TestIsOpeningElement(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        assert subject.is_opening_element(ifc.createIfcWall()) is False
+        assert subject.is_opening_element(ifc.createIfcOpeningElement()) is True
+
+
+class TestRunGeometryAddRepresntation(NewFile):
+    def test_nothing(self):
+        pass